-
Notifications
You must be signed in to change notification settings - Fork 57
Clean build and translation tools #98
Clean build and translation tools #98
Conversation
Now we use Transifex to update translations, that mean that we'll use the standard Transifex cient to update our source code according to resource configuiration made in /.tx/config file
I've just added a commit to fix the exclude list: up to now, the .git directory wasn't correctly excluded and I had some 10 Mio xpi files generated. I remove the PS: Github don't show here in the discussion page, but you can see it in the commit history. |
I've added another commit to set the default target of the Makefile to be the simple |
Wouldn't it be possible to execute transifex from a Make target? It would make building releases much easier for a maintainer when there are no manual commands needed other than launching the build itself. |
I think it would be possible but it will requires:
Does it make sense for you ? |
Well, I've just added translation targets and release target. Note, that the VERSION file will still require a manuall update before making a release as it's not easy to automatically increment a string like "4.0.0-beta4". Note also that the Makefile defines a |
|
||
l10n-auto-commit: l10n-get | ||
git add -- locale interfaces/exchangeAddressBook/locale/ | ||
-git commit -m 'l10n: automatic translations updates' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dash prefix is the way for Makefiles to say "execute this line and if you get an error, continue anyway the rest of the script".
Here, it allows us to continue the script even if nothing needs to be committed (the return value of the git command is non-zero if there was nothing to commit).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got to love Makefile syntax :D
@Trim Release process sounds good for now. This is already much better than before. If there are still issues we can update it again later. Updating the version file is ok, too. Once 4.0 is ready, I'd like to merge all this into |
Create a Makefile to replace build.sh script.
Remove unused translator update script as the Transifex will do the same (from
en
locale instead ofen-us
).Note: this PR comes from a split of #70 with more tested Makefile (beautify target is ready to be used)