Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): distinct + sort #3677

Merged
merged 30 commits into from
Jan 15, 2025

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into conn…

a189caf
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): distinct + sort #3677

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into conn…
a189caf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 15, 2025 in 1s

53.22% of diff hit (target 77.85%)

View this Pull Request on Codecov

53.22% of diff hit (target 77.85%)

Annotations

Check warning on line 104 in src/daft-connect/src/translation/expr/unresolved_function.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/expr/unresolved_function.rs#L104 

Added line #L104 was not covered by tests

Check warning on line 219 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L219 

Added line #L219 was not covered by tests

Check warning on line 239 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L239 

Added line #L239 was not covered by tests

Check warning on line 250 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L247-L250 

Added lines #L247 - L250 were not covered by tests

Check warning on line 256 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L253-L256 

Added lines #L253 - L256 were not covered by tests

Check warning on line 259 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L258-L259 

Added lines #L258 - L259 were not covered by tests

Check warning on line 262 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L261-L262 

Added lines #L261 - L262 were not covered by tests

Check warning on line 266 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L264-L266 

Added lines #L264 - L266 were not covered by tests

Check warning on line 270 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L269-L270 

Added lines #L269 - L270 were not covered by tests

Check warning on line 275 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L272-L275 

Added lines #L272 - L275 were not covered by tests

Check warning on line 280 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L278-L280 

Added lines #L278 - L280 were not covered by tests

Check warning on line 284 in src/daft-connect/src/translation/logical_plan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/daft-connect/src/translation/logical_plan.rs#L283-L284 

Added lines #L283 - L284 were not covered by tests
View more details on Codecov