Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connect): distinct + sort #3677

Merged
merged 30 commits into from
Jan 15, 2025

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into conn…

a189caf
Select commit
Loading
Failed to load commit list.
Merged

feat(connect): distinct + sort #3677

Merge branch 'main' of https://github.com/Eventual-Inc/Daft into conn…
a189caf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 15, 2025 in 0s

75.92% (-1.94%) compared to 809e411

View this Pull Request on Codecov

75.92% (-1.94%) compared to 809e411

Details

Codecov Report

Attention: Patch coverage is 53.22581% with 29 lines in your changes missing coverage. Please review.

Project coverage is 75.92%. Comparing base (809e411) to head (a189caf).

Files with missing lines Patch % Lines
src/daft-connect/src/translation/logical_plan.rs 51.72% 28 Missing ⚠️
...onnect/src/translation/expr/unresolved_function.rs 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3677      +/-   ##
==========================================
- Coverage   77.85%   75.92%   -1.94%     
==========================================
  Files         729      728       -1     
  Lines       89983    91440    +1457     
==========================================
- Hits        70057    69425     -632     
- Misses      19926    22015    +2089     
Files with missing lines Coverage Δ
...onnect/src/translation/expr/unresolved_function.rs 83.15% <75.00%> (+8.96%) ⬆️
src/daft-connect/src/translation/logical_plan.rs 37.02% <51.72%> (+4.81%) ⬆️

... and 20 files with indirect coverage changes