Fetch Test: Completely Disabled Rulesets

[zoracon]

Date ran: 2020-04-17
Rulesets with all hosts that are nonfunctional in ways defined by check_rules.py were completely disabled.

Logic: (If all hosts nonfunctional, disable)

Fetch Test Rubric: #18866

Thinking
I wanted to clear out completely disabled rulesets first before moving on to round 2. That way we can make a more sane path of patching rules.

If for some reason that seems too intense, please consider the amount of hosts we load that are nonfunctional and weigh what outcomes are best for our users and load.

I am aware of issues #19034 and #19330 and want to amend these before moving to round two..

Attachments

• Diff patch of Full Fetch test and Diff Patch of disabled rules (applied to this PR): https://www.dropbox.com/s/rfd2i4o5n04cle6/diff%20patches.zip?dl=0

Let me know if you have issues with this link - Just click "continue to view" if it prompts you to login

Comments for review

• The adjusted rulesets are from the effects of having dangling references and then since they were touched, being run through proper coverage themselves. I wanted this PR to be just about those fully disabled but that's not possible with strict testing structure we have to prevent coverage problems in testing.

[zoracon]

Merging in this batch to wrap up this portion the work and running a ruleset release (Monday) to end this segment and have the rulesets reflect the changes.

With this portion of changes, it's become apparent the fetch errors will be persistent with each push no matter how many times I run it consecutively, which means I will definitely not do these fetch tests the same way as prior years and the way it was run in April. I plan to make some amendments to check_rules.py before running it again for smaller batches of rulesets. But completely disabled rulesets here should be cleaned up at the very least.

[J0WI]

Thank you for working on this! 🎉

[zoracon]

Thank you for working on this!

And thank you for the feedback!