Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Amend Check Rules Script for Future Fetch Tests #19714

Closed
1 of 3 tasks
zoracon opened this issue Oct 22, 2020 · 2 comments
Closed
1 of 3 tasks

Amend Check Rules Script for Future Fetch Tests #19714

zoracon opened this issue Oct 22, 2020 · 2 comments

Comments

@zoracon
Copy link
Contributor

zoracon commented Oct 22, 2020

Items that need attention for test/rules/src/https_everywhere_checker/check_rules.py script in result from postmortem review on last Fetch Test

@pipboy96
Copy link
Contributor

pipboy96 commented Oct 22, 2020

@zoracon Can we re-enable rulesets marked as "failed ruleset test" before testing?

If you find rulesets with functional hosts that were previously marked as disabled, you can re-enable with updated rulesets.

@zoracon
Copy link
Contributor Author

zoracon commented Oct 29, 2020

@zoracon Can we re-enable rulesets marked as "failed ruleset test" before testing?

If you find rulesets with functional hosts that were previously marked as disabled, you can re-enable with updated rulesets.

Sorry if I misunderstand the question. Ultimately, if you see a disabled rulesets that are functional again, you can take those on. If you mean run a check on previously disabled rulesets as prep for a fetch test, that can be considered. I plan to run these tests in much smaller batches/more frequently.

@zoracon zoracon pinned this issue Nov 17, 2020
@zoracon zoracon unpinned this issue Jan 5, 2021
@zoracon zoracon closed this as completed Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants