fix serializing for array type attributes #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safakferhatkaya
changed the title
safakferhatkaya
changed the title
|
hey hey, could you please check if #176 solves the issue? I merged that one cause there were specs 😅 |
|
hey, yes #176 serves the same purpose its ok. thanks |
|
[duplicated] #176 resolves the same issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the introduction of #171,
we are still facing the issue of serializing after, #173. For
to_array_typeattributes.Description quoted from #173:
This PR first checks if the array is empty, before validating if all values are
StoreModel::Modelobjects. For many many_base class objects