Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue for empty nested array #173

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Fixed issue for empty nested array #173

merged 2 commits into from
Jun 4, 2024

Conversation

manuelvanrijn
Copy link
Contributor

@manuelvanrijn manuelvanrijn commented Jun 3, 2024 •
edited
Loading

After the introduction of #171, I found an issue with my nested model containing an array with no elements in it (due to default: []).

This PR first checks if the array is empty, before validating if all values are StoreModel::Model objects.

safakferhatkaya
safakferhatkaya approved these changes Jun 3, 2024
View reviewed changes
Copy link

@safakferhatkaya safakferhatkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job. we will wait for this branch to merge to upgrade to 3.0.0.

safakferhatkaya referenced this pull request Jun 3, 2024
@osanay
Fix issue with serialization options not applied to nested objects (#171
1a8eb48 
)

Resolved an issue where nested `StoreModel::Model` objects did not
inherit serialization options when the `as_json` method was called.
To address this, added two attributes to `StoreModel::Model` to
ensure proper inheritance of serialization settings.
@phinze
Copy link

phinze commented Jun 3, 2024

Hi there, it looks like this did not land before the upgrade was released, so upgrading to 3.0.0 yields a lot of NoMethodError: undefined method 'serialize_unknown_attributes?' for nil:NilClass errors.

Do you think you could merge this and cut a bugfix release?

@phinze phinze mentioned this pull request Jun 3, 2024
Closed
DmitryTsepelev
DmitryTsepelev approved these changes Jun 4, 2024
View reviewed changes
Copy link
Owner

@DmitryTsepelev DmitryTsepelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm going to release 3.0.1 right away, thank you so much ☺️

@DmitryTsepelev DmitryTsepelev merged commit c5220d0 into DmitryTsepelev:master Jun 4, 2024
16 checks passed
@safakferhatkaya safakferhatkaya mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryTsepelev DmitryTsepelev DmitryTsepelev approved these changes

@safakferhatkaya safakferhatkaya safakferhatkaya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manuelvanrijn @phinze @DmitryTsepelev @safakferhatkaya