Restore behavior to always store unknown attributes in the database

docs/unknown_attributes.md

@@ -46,4 +46,4 @@ configuration = Configuration.to_type.cast_value(color: "red", archived: true)
 configuration.as_json(serialize_unknown_attributes: true) # => {"color": "red", "archived": true}
 ```
 
-Prior to version 2.1.1, unknown attributes are always stored in the database. However, starting from version 2.1.1, if `serialize_unknown_attributes` is set to `false`, unknown attributes will not be stored in the database.
+In any case unknown attributes are always stored in the database.

lib/store_model/types/one.rb

@@ -47,7 +47,7 @@ def cast_value(value)
       def serialize(value)
         case value
         when @model_klass, Hash
-          ActiveSupport::JSON.encode(value)
+          ActiveSupport::JSON.encode(value, serialize_unknown_attributes: true)
         else
           super
         end

spec/store_model/types/many_polymorphic_spec.rb

@@ -9,11 +9,19 @@
     [
       {
         color: "red",
-        disabled_at: Time.new(2019, 2, 22, 12, 30).utc
+        model: nil,
+        active: true,
+        disabled_at: Time.new(2019, 2, 22, 12, 30).utc,
+        encrypted_serial: nil,
+        type: "left"
       },
       {
         color: "green",
-        disabled_at: Time.new(2019, 3, 12, 8, 10).utc
+        model: nil,
+        active: false,
+        disabled_at: Time.new(2019, 3, 12, 8, 10).utc,
+        encrypted_serial: nil,
+        type: "right"
       }
     ]
   end
@@ -195,5 +203,27 @@
       let(:value) { ActiveSupport::JSON.encode(attributes_array) }
       include_examples "serialize examples"
     end
+
+    context "when Array of instances is passed" do
+      let(:value) { attributes_array.map { |attrs| Configuration.new(attrs) } }
+      include_examples "serialize examples"
+
+      context "with unknown attributes" do
+        before do
+          value.each_with_index { |v, index| v.unknown_attributes[:archived] = index.even? }
+        end
+
+        [true, false].each do |serialize_unknown_attributes|
+          it "always includes unknown attributes regardless of the serialize_unknown_attributes option" do
+            StoreModel.config.serialize_unknown_attributes = serialize_unknown_attributes
+            expect(subject).to eq(
+              attributes_array.map.with_index do |attrs, index|
+                attrs.merge(value[index].unknown_attributes)
+              end.to_json
+            )
+          end
+        end
+      end
+    end
   end
 end

spec/store_model/types/many_spec.rb

@@ -9,11 +9,19 @@
     [
       {
         color: "red",
-        disabled_at: Time.new(2019, 2, 22, 12, 30).utc
+        model: nil,
+        active: true,
+        disabled_at: Time.new(2019, 2, 22, 12, 30).utc,
+        encrypted_serial: nil,
+        type: "left"
       },
       {
         color: "green",
-        disabled_at: Time.new(2019, 3, 12, 8, 10).utc
+        model: nil,
+        active: false,
+        disabled_at: Time.new(2019, 3, 12, 8, 10).utc,
+        encrypted_serial: nil,
+        type: "right"
       }
     ]
   end
@@ -162,5 +170,27 @@
       let(:value) { ActiveSupport::JSON.encode(attributes_array) }
       include_examples "serialize examples"
     end
+
+    context "when Array of instances is passed" do
+      let(:value) { attributes_array.map { |attrs| Configuration.new(attrs) } }
+      include_examples "serialize examples"
+
+      context "with unknown attributes" do
+        before do
+          value.each_with_index { |v, index| v.unknown_attributes[:archived] = index.even? }
+        end
+
+        [true, false].each do |serialize_unknown_attributes|
+          it "always includes unknown attributes regardless of the serialize_unknown_attributes option" do
+            StoreModel.config.serialize_unknown_attributes = serialize_unknown_attributes
+            expect(subject).to eq(
+              attributes_array.map.with_index do |attrs, index|
+                attrs.merge(value[index].unknown_attributes)
+              end.to_json
+            )
+          end
+        end
+      end
+    end
   end
 end

spec/store_model/types/one_polymorphic_spec.rb

@@ -249,6 +249,19 @@
     context "when Configuration instance is passed" do
       let(:value) { Configuration.new(attributes) }
       include_examples "serialize examples"
+
+      context "with unknown attributes" do
+        before do
+          value.unknown_attributes[:archived] = true
+        end
+
+        [true, false].each do |serialize_unknown_attributes|
+          it "always includes unknown attributes regardless of the serialize_unknown_attributes option" do
+            StoreModel.config.serialize_unknown_attributes = serialize_unknown_attributes
+            expect(subject).to eq(attributes.merge(value.unknown_attributes).to_json)
+          end
+        end
+      end
     end
   end
 end

spec/store_model/types/one_spec.rb

@@ -198,6 +198,19 @@
       it { is_expected.to be_a(String) }
 
       it("is equal to attributes") { is_expected.to eq(attributes.merge(type: nil).to_json) }
+
+      context "with unknown attributes" do
+        before do
+          value.unknown_attributes[:archived] = true
+        end
+
+        [true, false].each do |serialize_unknown_attributes|
+          it "always includes unknown attributes regardless of the serialize_unknown_attributes option" do
+            StoreModel.config.serialize_unknown_attributes = serialize_unknown_attributes
+            expect(subject).to eq(attributes.merge(type: nil, **value.unknown_attributes).to_json)
+          end
+        end
+      end
     end
   end