Restore behavior to always store unknown attributes in the database #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts the behavior of always storing unknown attributes in the database as it was in versions prior to 2.1.1, regardless of the value of the `serialize_unknown_attributes` option.
…nknown attributes This commit adds tests to each `Type` class's `serialize` method to ensure that unknown attributes are included in the serialization output, regardless of the `serialize_unknown_attributes` option.
|
LGTM! Maybe I'll just roll out a major release 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our application uses StoreModel with the
serialize_unknown_attributesoption set tofalse.Previously, StoreModel versions prior to 2.1.1 always stored unknown attributes in the database. However, now, unknown attributes are not stored unless the
serialize_unknown_attributesoption is set totrue. This change was inconvenient for us; therefore, we want to restore the behavior of storing unknown attributes in the database, regardless of the setting of theserialize_unknown_attributesoption.The fix was straightforward. Furthermore, to ensure this behavior does not break, I have improved the tests for the
serializemethod in eachTypeclass.However, this change will again alter the behavior of storing unknown attributes in the database. I considered adding an option to choose whether to store unknown attributes or not. The challenge, then, is deciding what the default value for this new option should be. Considering current users who have the
serialize_unknown_attributesoption enabled, the default should logically be to store. Ultimately, this would amount to a similar breaking change.Nevertheless, it simply restores the behavior of the previous version.