Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lucky drop schema #6093

Merged
merged 3 commits into from
Apr 18, 2022
Merged

fix: lucky drop schema #6093

merged 3 commits into from
Apr 18, 2022

Conversation

zhouhanseng
Copy link
Contributor

@zhouhanseng zhouhanseng commented Apr 17, 2022 •
edited
Loading

Description

Closes # (NO_ISSUE)

https://mask.atlassian.net/browse/MF-456

Type of change

  • Documentation
  • Code refactoring (Restructuring existing code w/o changing its observable behavior)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would make something no longer possible to do/require old user must upgrade their Mask Network to this new version)

Previews

Checklist

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
    • I have removed all in development console.logs
    • I have removed all commented code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have read Internationalization Guide and moved text fields to the i18n JSON file.

If this PR depends on external APIs:

  • I have configured those APIs with CORS headers to let extension requests get passed.
    • chrome extension: chrome-extension://[id]
    • firefox extension: moz-extension://[id]
  • I have delegated all web requests to the background service via the internal RPC bridge.

zhouhanseng
zhouhanseng commented Apr 17, 2022
View reviewed changes
packages/mask/src/plugins/RedPacket/schema.json
@@ -87,7 +87,7 @@
"title": "symbol"
}
},
"required": ["address", "decimals", "name", "symbol"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"decimals", "name", "symbol" can be fetched later, since sheer size of payload would cause encoded image not work.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2022 •
edited
Loading

🚀 Deployed on https://625cc06dbef9c24bd79e6491--compassionate-northcutt-326a3a.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 17, 2022 10:50 Inactive
@zhouhanseng zhouhanseng changed the title chore: lucky drop schema fix: lucky drop schema Apr 17, 2022
@github-actions github-actions bot temporarily deployed to pull request April 17, 2022 11:09 Inactive
septs
septs reviewed Apr 17, 2022
View reviewed changes
packages/mask/src/plugins/RedPacket/SNSAdaptor/RedPacket/index.tsx Outdated
@@ -63,7 +63,10 @@ export function RedPacket(props: RedPacketProps) {
: EthereumTokenType.ERC20),
payload.token?.address ?? payload.token_address ?? '',
)
const token = payload.token ?? tokenDetailed
const token =
payload.token && ['chainId', 'decimal', 'symbol'].every((k) => k in (payload.token ?? {}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
payload.token && ['chainId', 'decimal', 'symbol'].every((k) => k in (payload.token ?? {}))
payload.token && ['chainId', 'decimal', 'symbol'].every((k) => Reflect.has(payload.token, k))

@github-actions github-actions bot temporarily deployed to pull request April 18, 2022 01:35 Inactive
@guanbinrui guanbinrui merged commit b6b6686 into develop Apr 18, 2022
@guanbinrui guanbinrui deleted the hancheng/fix-rp-history branch April 18, 2022 09:07
nuanyang233 pushed a commit that referenced this pull request Apr 18, 2022
@zhouhanseng @nuanyang233
fix: lucky drop schema (#6093)
a608804 
* chore: lucky drop schema

* chore: lucky drop schema

* chore: reply code review
guanbinrui added a commit that referenced this pull request Apr 20, 2022
@nuanyang233 @BillySh1
@guanbinrui @septs @Jack-Works @zhouhanseng
feat: improve mask popup (#5986)
e8aac37 
* feat: upgrade mask wallet setting page

* feat: popup bottom navigator

* feat: new header for popup

* fix: adjust header for ssr

* fix: build error

* fix: prettier

* refactor: split smart and dumb component

* fix: bugfix

* fix: icon

* fix: bugfix

* fix: bugfix

* feat: new persona page

* fix: bugfix

* fix: bugfix

* fix: bugfix

* fix: network icon

* fix: bugfix

* fix: bugfix for header

* fix: build error

* feat: popup nextid (#6028)

* feat: compo steps init

* fix: ui

* fix: fix

* fix: kill unused code

* feat: slient sign

* fix: fix

* fix: fix

* feat: connect wallet page

* fix: typo

* fix: typo

* fix: comment

* refactor: temp

* refactor: refact steps compo

* fix: fix

Co-authored-by: nuanyang233 <nuanyang233@gmail.com>

* feat: connect wallet with persona

* feat: connect popup wallet (#6081)

* feat: impl the connect page

* refactor: replace mm logo

* fix: bugfix

* fix: bugfix

* fix: reply to commnts

* fix: typo

* fix: typo again

* chore: improve eslint (#6084)

* chore: improve eslint

* revert: file

* fix: eslintrc

* chore: setup i18n in background (#6086)

* fix: revert remove i18n key

* fix: remove wallet sign

* fix: temp

* feat: popup connect wallet (#6088)

* fix: personalSign

* refactor: replace NetworkType with ChainId

* fix: popup connect wallet

* fix: bugfix

* feat: popup custom snackbar

* fix: eslint

* fix: fix

* fix: delete unused code

* fix: ui

* refactor: move verify wallet to persona

* fix: navigate replace

* fix: ui issues

* fix: refresh proofs when bound

* chore: ui style

* fix: persona max length

* fix: persona max length

* chore: reply review

* fix: i18n init twice in wrong context

* feat: add loading at connected wallets page

* fix: reply to coments

* fix: locales

* fix: disable open new window when sign on popup

* fix: pos

* fix: replace

* fix: steps btn loading

* fix: navigate back when wallet sign success

* refactor: replace useState to useAsyncFn

* fix: adjust connect wallet step

* fix: err state

* fix: go back when wallet signed

* fix: bugfix

* fix:  wallet name

* feat: add ECKeyIdentifier.publicKeyAsHex close GH-6082 (#6085)

* refactor: cleanup post context (#6089)

* refactor: cleanup code

* feat: add transaction dialog in saving plugin (#6076)

* feat: add transaction dialog in saving plugin

* fix: bugfix

* fix: reset state when transaction has been confirmed

* refactor: cleanup code

* refactor: cleanup code and add deprecations

* chore: improve code style (#6090)

* chore: change iOS idb fix

* fix: incorrect text (#6096)

* refactor: move backup code to backup-format package (#5922)

* refactor: move backup code to backup-format package

* wip

* feat: impl generate backup

* refactor: rename file

* store

* refactor: impl addUnconfirmedBackup

* refactor: impl getUnconfirmedBackup

* refactor: impl restoreUnconfirmedBackup

* refactor: impl all wrapper

* refactor: impl post restore

* refactor: impl wallet and plugin restore

* refactor: move unused file

* chore: misc

* chore: misc

* chore: misc

* fix: bugs

* fix: type error

* chore: remove one alias

* chore: remove unused string

* fix: lockfile

* fix: type error

* fix: two bugs

* fix: lucky drop schema (#6093)

* chore: lucky drop schema

* chore: lucky drop schema

* chore: reply code review

* fix: incorrect contracts query on dashboard (#6095)

* refactor: move some functions

* refactor: move detachProfileWithNextID

* refactor: move queryPersonaByPrivateKey

* refactor: move resolveUnknownLegacyIdentity

* refactor: move relation methods

* refactor: move attach/detach profile

* refactor: move mobile_restoreFromMnemonicWords

* refactor: move downloadBackup

* refactor: move createPersonaByMnemonic

* refactor: move openDashboard

* refactor: rename WelcomeService to BackupService

* fix: bugfix

* chore: reply review

* fix: reply

* chore: improve network icon at select wallet page

* fix: sign request with verify wallet

* fix: bugfix

* fix: bugfix

* fix: code review (#6105)

* fix: hash router

* fix: select wallet

* fix: sign with non-default wallet

* chore: i18n

* fix: lint error

Co-authored-by: BillyS <Billy@mask.io>
Co-authored-by: guanbinrui <52657989+guanbinrui@users.noreply.github.com>
Co-authored-by: septs <github@septs.pw>
Co-authored-by: Jack Works <jackworks@protonmail.com>
Co-authored-by: Hancheng Zhou <z308114274@gmail.com>
Co-authored-by: guanbinrui <guanbinrui@dimension.im>
@guanbinrui guanbinrui mentioned this pull request Apr 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@septs septs septs left review comments

@guanbinrui guanbinrui guanbinrui approved these changes

Assignees
No one assigned
Labels
Test: Tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhouhanseng @septs @guanbinrui @wenluomask