Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard stage 2 #427

Merged
merged 77 commits into from
Dec 18, 2019
Merged

Dashboard stage 2 #427

merged 77 commits into from
Dec 18, 2019

Conversation

SunriseFox
Copy link
Contributor

@SunriseFox SunriseFox commented Nov 26, 2019 •
edited
Loading

This closes #369, #407, #493

Two to resolve:

  1. no confirm button here, what about adding a floating button to confirm import? @neruthes

image

  1. database throws on multiple imports of the same file (files that contain the same persona) @Jack-Works

@SunriseFox SunriseFox force-pushed the dashboard-st2 branch 3 times, most recently from e5babcc to b51c940 Compare December 3, 2019 08:53
@SunriseFox SunriseFox force-pushed the dashboard-st2 branch 5 times, most recently from 0c6ba55 to f22d667 Compare December 9, 2019 06:26
@SunriseFox SunriseFox marked this pull request as ready for review December 11, 2019 10:05
Jack-Works
Jack-Works requested changes Dec 13, 2019
View reviewed changes
@SunriseFox
Copy link
Contributor Author

@Jack-Works you may freely change them by your self.

guanbinrui
guanbinrui previously approved these changes Dec 17, 2019
View reviewed changes
@neruthes
Copy link
Contributor

image

image

Bug? 🤔

@neruthes neruthes mentioned this pull request Dec 17, 2019
Closed
@Jack-Works Jack-Works self-requested a review December 17, 2019 08:16
Jack-Works
Jack-Works previously approved these changes Dec 17, 2019
View reviewed changes
Jack-Works
Jack-Works previously approved these changes Dec 17, 2019
View reviewed changes
@Jack-Works Jack-Works merged commit bdc7c90 into master Dec 18, 2019
@Jack-Works Jack-Works deleted the dashboard-st2 branch December 18, 2019 14:26
@SunriseFox SunriseFox mentioned this pull request Dec 19, 2019
Closed
@neruthes
Copy link
Contributor

image

https://www.figma.com/file/oFrOUZmDnOWL2pu6SNf4P7/Dashboard-v2?node-id=2081%3A0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Works Jack-Works Jack-Works approved these changes

@guanbinrui guanbinrui guanbinrui approved these changes

@neruthes neruthes Awaiting requested review from neruthes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard Revamp (Stage 2)
4 participants
@SunriseFox @neruthes @Jack-Works @guanbinrui