Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demand] Dashboard Revamp (Stage 3: Export Persona as QR) #493

Closed
neruthes opened this issue Dec 9, 2019 · 5 comments
Closed

[Demand] Dashboard Revamp (Stage 3: Export Persona as QR) #493

neruthes opened this issue Dec 9, 2019 · 5 comments

Comments

@neruthes
Copy link
Contributor

neruthes commented Dec 9, 2019

Metadata

Field Value
Previous Stage #369
Figma Link figma.com/...
Expected UX prototype due -
Actual UX prototype release -
Expected engineering due 2019-12-15
Corresponding Pull Request -
Completion Version -

Content

image

The third option in "Backup Persona" panel.

Notes

  • The "Backup Persona" panel should always have the same height.
  • Implement this after Dashboard Revamp (Stage 2) #369 and ship both in the same release.
  • Payload format is not defined. Feel free to use any arbitrary format without documentation.
@Jack-Works
Copy link
Member

type QRRepresentation = [
    ProfileIdentifier['network'], // string
    ProfileIdentifier['userId'], // string
    Profile['nickname'], // string
    JsonWebKey['k'],  // LocalKey, string
    string, // Compressed publicKey
    string, // Compressed privateKey
    string, // BackupJSONFileLatest['grantedHostPermissions'].join(';'),
]

@SunriseFox
Copy link
Contributor

The "Backup Persona" panel should always have the same height

I don't think this could be done without specifying a fixed height, e.g., 200px

@neruthes
Copy link
Contributor Author

The "Backup Persona" panel should always have the same height

I don't think this could be done without specifying a fixed height, e.g., 200px

image

Let the box be 292px for now. The height of the QR code image is 260px. The vertical padding is 16px.

@SunriseFox
Copy link
Contributor

We also need something like 'import QR' or it would be useless. By the way, please update Figma.

@neruthes
Copy link
Contributor Author

We also need something like 'import QR' or it would be useless. By the way, please update Figma.

I will create another Demand issue to specify the behavior of importing QR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants