chore: improve eslint (#6084)

* chore: improve eslint

* revert: file

* fix: eslintrc

package.json

@@ -47,16 +47,16 @@
     "lodash-unified": "1.0.2",
     "react": "18.0.0",
     "react-dom": "18.0.0",
-    "ses": "0.15.12",
     "react-i18next": "^11.16.5",
+    "ses": "0.15.12",
     "ts-results": "3.3.0",
     "web3-core": "1.7.3",
     "web3-core-method": "1.7.3"
   },
   "devDependencies": {
     "@commitlint/cli": "^16.2.3",
     "@commitlint/config-conventional": "^16.2.1",
-    "@dimensiondev/eslint-plugin": "^0.0.1-20220117062517-fd3cb01",
+    "@dimensiondev/eslint-plugin": "^0.0.2-20220414093950-7d54c58",
     "@dimensiondev/patch-package": "^6.5.0",
     "@jest/globals": "^28.0.0-alpha.8",
     "@magic-works/i18n-codegen": "^0.1.0",

packages/.eslintrc.json

@@ -65,15 +65,19 @@
         "unicorn/prefer-number-properties": "error",
         "unicorn/relative-url-style": ["error", "always"],
         "unicorn/throw-new-error": "error",
-        "@dimensiondev/no-jsx-template-literal": "error",
-        "@dimensiondev/no-locale-case": "error",
+        "@dimensiondev/array/no-implicit-sort": "error",
+        "@dimensiondev/browser/prefer-location-assign": "error",
+        "@dimensiondev/jsx/no-class-component": "error",
+        "@dimensiondev/jsx/no-template-literal": "error",
         "@dimensiondev/no-number-constructor": "off",
-        "@dimensiondev/no-simple-string-interpolation": "off",
-        "@dimensiondev/no-simple-template-literal": "error",
-        "@dimensiondev/no-unneeded-to-string": "error",
         "@dimensiondev/prefer-early-return": "error",
-        "@dimensiondev/prefer-location-assign": "error",
-        "@dimensiondev/unicode-specific-set": "error",
+        "@dimensiondev/string/no-interpolation": "off",
+        "@dimensiondev/string/no-locale-case": "error",
+        "@dimensiondev/string/no-simple-template-literal": "error",
+        "@dimensiondev/string/no-unneeded-to-string": "error",
+        "@dimensiondev/type/no-instanceof-wrapper": "error",
+        "@dimensiondev/type/no-wrapper-type-reference": "error",
+        "@dimensiondev/unicode/specific-set": "error",
         "@typescript-eslint/await-thenable": "error",
         "@typescript-eslint/no-base-to-string": "off",
         "@typescript-eslint/no-for-in-array": "error",

packages/dashboard/src/pages/Settings/components/LanguageSetting.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable @dimensiondev/unicode-specific-set */
+/* eslint-disable @dimensiondev/unicode/specific-set */
 import { MenuItem } from '@mui/material'
 import { useLanguage } from '../api'
 import { Services } from '../../../API'

packages/dashboard/src/utils/checkLengthExceed.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 export const PERSONA_NAME_MAX_LENGTH = 24
 export function isPersonaNameLengthValid(value: string) {
     // Array.from(string).length is not equal to string.length.

packages/encryption/src/payload_internal/version-38.encoder.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import { encodeText, encodeArrayBuffer } from '@dimensiondev/kit'
 import { Ok, Option, Result } from 'ts-results'
 import type { PayloadWellFormed, Signature } from '..'

packages/encryption/src/payload_internal/version-38.parser.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import { EC_Key, PayloadParseResult, EC_KeyCurveEnum, Signature } from '../payload'
 import { CryptoException, PayloadException } from '../types'
 import { Result, Ok, Some } from 'ts-results'

packages/encryption/src/payload_internal/version-39.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import { parse40 } from './version-40'
 import { PayloadException } from '../types'
 import type { PayloadParserResult } from '.'

packages/encryption/src/payload_internal/version-40.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import type { PayloadParseResult, Signature } from '../payload'
 import { Ok } from 'ts-results'
 import { PayloadException } from '../types'

packages/mask/background/services/crypto/comment.ts

@@ -1,7 +1,7 @@
 import { encodeArrayBuffer, decodeText, decodeArrayBuffer, encodeText } from '@dimensiondev/kit'
 import type { AESCryptoKey } from '@masknet/shared-base'
 
-// eslint-disable-next-line @dimensiondev/unicode-specific-set
+// eslint-disable-next-line @dimensiondev/unicode/specific-set
 // * Payload format: 🎶2/4|encrypted_comment:||
 export async function encryptComment(postIV: Uint8Array, postContent: string, comment: string): Promise<string> {
     const key = await getCommentKey(postIV, postContent)

packages/mask/src/plugins/ArtBlocks/types.ts

@@ -1,5 +1,5 @@
 export interface Token {
-    tokenId: BigInt
+    tokenId: bigint
     contract: Contract
     project: Project
 }

packages/mask/src/plugins/ITO/SNSAdaptor/ExchangeTokenPanel.tsx

@@ -91,7 +91,9 @@ export function ExchangeTokenPanel(props: ExchangeTokenPanelProps) {
         isSell,
         dataIndex,
         exchangeToken?.address,
+        // eslint-disable-next-line @dimensiondev/array/no-implicit-sort
         excludeTokensAddress.sort().join(),
+        // eslint-disable-next-line @dimensiondev/array/no-implicit-sort
         selectedTokensAddress.sort().join(),
     ])
     // #endregion

packages/mask/src/plugins/ITO/SNSAdaptor/SwapDialog.tsx

@@ -159,6 +159,7 @@ export function SwapDialog(props: SwapDialogProps) {
         pickToken,
         exchangeTokens
             .map((x) => x.address)
+            // eslint-disable-next-line @dimensiondev/array/no-implicit-sort
             .sort()
             .join(),
     ])

packages/mask/src/plugins/Pets/SNSAdaptor/Drag.tsx

@@ -23,6 +23,7 @@ interface DraggableProps {
 }
 
 // TODO: move to function components
+// eslint-disable-next-line @dimensiondev/jsx/no-class-component -- TODO: need refactor
 class Draggable extends React.PureComponent<React.PropsWithChildren<DraggableProps>> {
     ref = React.createRef<HTMLDivElement | null>()
     mouseMoveFuc = this.onMouseMove.bind(this)

packages/mask/src/plugins/Trader/trending/useCurrentDataProvider.ts

@@ -13,6 +13,10 @@ export function useCurrentDataProvider(availableDataProviders: DataProvider[]) {
         setDataProvider(
             availableDataProviders.includes(currentDataProvider) ? currentDataProvider : availableDataProviders[0],
         )
-    }, [availableDataProviders.sort().join(), currentDataProvider])
+    }, [
+        // eslint-disable-next-line @dimensiondev/array/no-implicit-sort
+        availableDataProviders.sort().join(),
+        currentDataProvider,
+    ])
     return dataProvider
 }

packages/mask/src/plugins/UnlockProtocol/Services.ts

@@ -21,7 +21,7 @@ export interface verifyHolderResponse {
     }[]
 }
 
-const verifyHolder = async <verifyHolderResponse>(_lockAddress: String, _holder: String, _chain: number) => {
+const verifyHolder = async <verifyHolderResponse>(_lockAddress: string, _holder: string, _chain: number) => {
     const query = gql`
         query keyHolders($address: String!) {
             keyHolders(where: { address: $address }) {
@@ -59,7 +59,7 @@ const verifyActiveLock = (data: { lock: string; address: string; chain: number }
     })
 }
 
-export const verifyPurchase = async (_userAddress: String, _lockAddress: String, _lockChain: number) => {
+export const verifyPurchase = async (_userAddress: string, _lockAddress: string, _lockChain: number) => {
     const query = gql`
         query locks($address: String!) {
             locks(where: { address: $address }) {
@@ -87,7 +87,7 @@ export const verifyPurchase = async (_userAddress: String, _lockAddress: String,
     return flag
 }
 
-export const getLocks = async <UnlockLocks>(_address1: String) => {
+export const getLocks = async <UnlockLocks>(_address1: string) => {
     const query = gql`
         query lockManager($address: String!) {
             lockManagers(where: { address: $address }) {

packages/mask/src/social-network-adaptor/twitter.com/injection/PostInspector.tsx

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import type { PostInfo } from '@masknet/plugin-infra/content-script'
 import { injectPostInspectorDefault } from '../../../social-network/defaults/inject/PostInspector'
 import { twitterEncoding } from '../encoding'

packages/mask/src/utils/getTextUILength.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 export function getTextUILength(text: string) {
     return Array.from(text).reduce((acc, char) => acc + getCharUILength(char), 0)
 }

packages/mask/src/utils/type-transform/Payload.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import type { SocialNetwork } from '../../social-network'
 import { isEnvironment, Environment } from '@dimensiondev/holoflows-kit'
 import { i18n } from '../../../shared-ui/locales_legacy'

packages/plugin-infra/src/types.ts

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import type React from 'react'
 import type { Option, Result } from 'ts-results'
 import type { TypedMessage } from '@masknet/typed-message'

packages/plugins/example/src/SNSAdaptor/index.tsx

@@ -1,4 +1,4 @@
-/* eslint @dimensiondev/unicode-specific-set: ["error", { "only": "code" }] */
+/* eslint @dimensiondev/unicode/specific-set: ["error", { "only": "code" }] */
 import type { Plugin } from '@masknet/plugin-infra'
 import { base } from '../base'
 

packages/shared-base/src/Identifier/type.ts

@@ -74,6 +74,7 @@ export abstract class Identifier {
     static IdentifiersToString(a: Identifier[], isOrderImportant = false) {
         const ax = a.map((x) => x.toText())
         if (!isOrderImportant) {
+            // eslint-disable-next-line @dimensiondev/array/no-implicit-sort
             ax.sort()
         }
         return ax.join(',')

packages/shared/src/UI/components/ERC20TokenList/index.tsx

@@ -115,6 +115,7 @@ export const ERC20TokenList = memo<ERC20TokenListProps>((props) => {
         assetsLoading,
         assets
             .map((x) => x.token.address)
+            // eslint-disable-next-line @dimensiondev/array/no-implicit-sort
             .sort()
             .join(),
     ])

packages/web3-shared/evm/hooks/useERC20TokensDetailedFromTokenLists.ts

@@ -21,6 +21,7 @@ export function useERC20TokensDetailedFromTokenLists(
     const { fetchERC20TokensFromTokenLists } = useWeb3Context()
     const { value: tokensFromList = EMPTY_LIST, ...asyncResult } = useAsyncRetry(
         async () => (!lists || lists.length === 0 ? [] : fetchERC20TokensFromTokenLists(lists, chainId)),
+        // eslint-disable-next-line @dimensiondev/array/no-implicit-sort
         [chainId, lists?.sort().join()],
     )
     // #endregion