Fix for the firing bug

[HarshNarayanJha]

I have fixed the bug stated in issue #18 by just checking if the space key was held for long enough to stop firing that weird looking continuous bullets.

Fixes #18

[DiddiLeija]

Hmm... I just ran the CI, and seems like black (the code formatter I'm using) is unhappy. To fix this, open your fork locally, in an environment with Nox installed, then run nox -s keep-codebase-clean. Then push the changes here.

If you prefer that I do the changes, tell me!

[DiddiLeija]

I also edited your first post to link this PR with the issue, so we can close it after merging.

[DiddiLeija]

I just tested locally. Indeed, the bug is now gone! 🎉

I can spot two things to make this PR ready:

1. Remove the print, at line 165? On a Windows distribution, this won't be visible, but other distributions will fill up with unecessary information. You can still use print for testing purposes, but don't push them here.
2. Fix the code formatting, see Fix for the firing bug #19 (review).

[HarshNarayanJha]

1. Remove the print, at line 165? On a Windows distribution, this won't be visible, but other distributions will fill up with unecessary information. You can still use print for testing purposes, but don't push them here.

Oh! Sorry, I forgot that one. Removed!

2. Fix the code formatting, see #19 (review).

I did it as you said, and here's the output:

But main.py wasn't changed. Is that OK?

[DiddiLeija]

Did you push the changes? On a Git local clone, run git add ., then run git commit --message "{Commit message}", and finally git push.

[HarshNarayanJha]

I will push the changes after confirming this: #18 (comment)
Also, before committing and pushing, all that I wanted to know is that nox did nothing to main.py when I ran the command. Won't this will cause CI checks to fail here again?

[HarshNarayanJha]

Pushed!

[DiddiLeija]

Also, before committing and pushing, all that I wanted to know is that nox did nothing to main.py when I ran the command. Won't this will cause CI checks to fail here again?

Hmm... It did, I don't know why. Did you run Nox in the same branch than the PR? Maybe that's the issue.

About the behavior changes, I will review them soon.

[HarshNarayanJha]

Ok! ran just nox command and it ran both tests, and this time it did reformat main.py, which was only rearrangement of some brackets on multiple lines.

Hopefully this time checks will pass!
Pushed the changes!

[HarshNarayanJha]

Hey! All checks passed @DiddiLeija!

[DiddiLeija]

Thanks @HarshNarayanJha! 🎉