Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire Bug #18

Closed
HarshNarayanJha opened this issue Jan 11, 2022 · 8 comments · Fixed by #19
Closed

Fire Bug #18

HarshNarayanJha opened this issue Jan 11, 2022 · 8 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@HarshNarayanJha
Copy link
Contributor

There is an graphical issue in bullet firing, where if you keep the space button held for more than two consecutive frames, then a long continuous row of bullets will appear onscreen, which doesn't causes any damage to enemies...

To fix this, I will soon open a PR
fire_bug

HarshNarayanJha added a commit to HarshNarayanJha/diddi-and-the-bugs that referenced this issue Jan 11, 2022
@HarshNarayanJha
Copy link
Contributor Author

Fixed, here's the PR: #19

@DiddiLeija
Copy link
Owner

Hmm... I'm wondering if this should be a bug, or just a "hard-to-find trick".

@DiddiLeija
Copy link
Owner

Well... I never tried to keep the space key pressed. Let's consider this a glitch, and fix it. Thanks for reporting @HarshNarayanJha!

@HarshNarayanJha
Copy link
Contributor Author

Hmm... I'm wondering if this should be a bug, or just a "hard-to-find trick".

But those continuous bullets don't hit.

@DiddiLeija
Copy link
Owner

They hit on my case 🤷‍♂️.

@DiddiLeija
Copy link
Owner

Hmm... maybe it works in the new Pyxel (1.6.1). If you ran using 1.5.8 (like in #20), the restart logics are broken and the fire bug is now functional?

Can you run pip install -U pyxel and recreate the behavior?

@HarshNarayanJha
Copy link
Contributor Author

Oh yes, updated to Pyxel(1.6.1). Two things happened:

  1. The bug's gone! Those continuous bullets are now killing enemies!
  2. Restart Bugs Issues with restarting the game #20 is confirmed.

So, disallowing is usage of continuous bullets (as I did before), is not a good idea. We should allow that "hard-to-find trick" (one easter egg done! congrats!). But I don't like the visual style of it....
Isn't this one nice?
image
(Already confirmed, they do hit!)

@DiddiLeija
Copy link
Owner

We should allow that "hard-to-find trick" (one easter egg done! congrats!)

😉

Isn't this one nice?

Yeah, it looks better. Thanks for the fix!

DiddiLeija pushed a commit that referenced this issue Jan 13, 2022
* fixed firing bug #18

* Patches to #19

* reformatted the code
@DiddiLeija DiddiLeija added the bug Something isn't working label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants