Skip to content
This repository was archived by the owner on Aug 30, 2019. It is now read-only.

cmd/trace-agent: reduce histogram calls in concentrator #522

Merged
merged 2 commits into from
Nov 8, 2018
Merged

cmd/trace-agent: reduce histogram calls in concentrator #522

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6a2848
cmd/trace-agent: remove per distribution metrics.
gbbr Nov 7, 2018
47278f4
cmd/trace-agent: only export bucket when needed in concentrator
gbbr Nov 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions cmd/trace-agent/concentrator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
log "github.com/cihub/seelog"

"github.com/DataDog/datadog-trace-agent/model"
"github.com/DataDog/datadog-trace-agent/statsd"
"github.com/DataDog/datadog-trace-agent/watchdog"
)

Expand Down Expand Up @@ -145,23 +144,14 @@ func (c *Concentrator) flushNow(now int64) []model.StatsBucket {

c.mu.Lock()
for ts, srb := range c.buckets {
bucket := srb.Export()

// Always keep `bufferLen` buckets (default is 2: current + previous one).
// This is a trade-off: we accept slightly late traces (clock skew and stuff)
// but we delay flushing by at most `bufferLen` buckets.
if ts > now-int64(c.bufferLen)*c.bsize {
continue
}

log.Debugf("flushing bucket %d", ts)
for _, d := range bucket.Distributions {
statsd.Client.Histogram("datadog.trace_agent.distribution.len", float64(d.Summary.N), nil, 1)
}
for _, d := range bucket.ErrDistributions {
statsd.Client.Histogram("datadog.trace_agent.err_distribution.len", float64(d.Summary.N), nil, 1)
}
sb = append(sb, bucket)
sb = append(sb, srb.Export())
delete(c.buckets, ts)
}

Expand Down