This repository was archived by the owner on Aug 30, 2019. It is now read-only.
cmd/trace-agent: reduce histogram calls in concentrator #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbbr
force-pushed
the
gbbr/stats-reduce
branch
2 times, most recently
from
4875242 to
a782fe6
Compare
|
I reduced the rate to 0.2, but not sure if this will alleviate the problem enough. |
|
Good catch, contrary to most metrics which we batch internally/report periodically, this one was done once per distribution. In practice, we never look at it. I'd suggest to simply remove it. |
These metrics were causing excessive UDP hits, errors and flooding. This change removes them.
This change moves the `bucket.Export` call to after the precondition where it is needed in an attempt to save some memory and CPU.
gbbr
force-pushed
the
gbbr/stats-reduce
branch
from
a782fe6 to
47278f4
Compare
|
Great! That's probably the best thing to do. Note that I've added another commit with a small improvement. PTAL. |
LotharSee
approved these changes
Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attemtp to reduce UDP hits and flooding.
We had reports of excessive UDP packets (>3000 per 10 seconds) for metric
datadog.trace_agent.err_distribution.len, all with values of zero. Seems uncalled for. This change should hopefully alleviate.