feat: Add handling for missing interstitial page #1775
jimwashbrook
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
code-pr-check.yml
on: pull_request
Get Directories for Linting
3s
Build database upgrader
27s
Run javascript tests
15s
Matrix: Lint & Commit
Build and run unit tests
1m 29s
Annotations
12 errors and 21 warnings
|
Lint & Commit (Dfe.PlanTech.Application/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.AzureFunctions/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.DatabaseUpgrader/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.Domain/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.Infrastructure.Contentful/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.Infrastructure.Data/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.Infrastructure.SignIn/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.Web.Node/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Lint & Commit (Dfe.PlanTech.Web/)
Received status code 403. Resource not accessible by integration https://docs.github.com/rest/checks/runs#create-a-check-run
|
|
Build and run unit tests:
tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetPageQueryTests.cs#L285
'GetPageQuery' does not contain a constructor that takes 6 arguments
|
|
Build and run unit tests:
tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetPageQueryTests.cs#L285
'GetPageQuery' does not contain a constructor that takes 6 arguments
|
|
Build and run unit tests
Process completed with exit code 1.
|
|
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build database upgrader
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Lint & Commit (Dfe.PlanTech.Application/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.AzureFunctions/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.DatabaseUpgrader/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.Domain/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.Infrastructure.Contentful/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.Infrastructure.Data/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.Infrastructure.SignIn/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.Web.Node/)
Some check runs could not be created.
|
|
Lint & Commit (Dfe.PlanTech.Web/)
Some check runs could not be created.
|
|
Build and run unit tests
The "--output" option isn't supported when building a solution. Specifying a solution-level output path results in all projects copying outputs to the same directory, which can lead to inconsistent builds.
|
|
Build and run unit tests:
tests/Dfe.PlanTech.Infrastructure.SignIn.UnitTests/DfeOpenIdConnectEventsTests.cs#L286
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
|
|
|
|
Build and run unit tests:
tests/Dfe.PlanTech.Application.UnitTests/Content/Queries/GetPageQueryTests.cs#L386
Dereference of a possibly null reference.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Routing/GetRecommendationRouter.cs#L72
Possible null reference argument for parameter 'page' in 'PageViewModel.PageViewModel(Page page, Controller controller, IUser user, ILogger logger)'.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Routing/CheckAnswersRouter.cs#L59
Dereference of a possibly null reference.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Controllers/CookiesController.cs#L48
Converting null literal or possible null value to non-nullable type.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Controllers/CookiesController.cs#L52
Dereference of a possibly null reference.
|
|
Build and run unit tests:
src/Dfe.PlanTech.Web/Controllers/CheckAnswersController.cs#L47
Number of parameters supplied in the logging message template do not match the number of named placeholders (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2017)
|