Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add handling for missing interstitial page #465

Merged
merged 5 commits into from
Jan 18, 2024
Merged

feat: Add handling for missing interstitial page #465

merged 5 commits into from
Jan 18, 2024

Conversation

jimwashbrook
Copy link
Contributor

  • Refactors database query logic from GetPageQuery to own class GetPageFromDbQuery
  • Add validation in GetCategorySectionsQuery to ensure that all sections have an InterstitialPage
  • Adds error catching in CategorySectionViewComponent if a section is missing an InterstitialPage

@jimwashbrook jimwashbrook merged commit e65f38f into development Jan 18, 2024
@jimwashbrook jimwashbrook deleted the fix/missing-interstitial-page-catching branch January 18, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uahussain12 uahussain12 uahussain12 approved these changes

@Iain-Stanger Iain-Stanger Iain-Stanger approved these changes

@Zac-Digital Zac-Digital Awaiting requested review from Zac-Digital

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimwashbrook @uahussain12 @Iain-Stanger