fix: cellline_materials add index and created_by column #2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
headri
changed the title
headri
changed the title
headri
force-pushed
the
261-cell-line-material-controls
branch
from
6b21093 to
1ef11e4
Compare
headri
force-pushed
the
261-cell-line-material-controls
branch
from
1ef11e4 to
5d32e53
Compare
LCOV of commit
|
LCOV of commit
|
JanCBrammer
reviewed
Mar 6, 2025
app/javascript/src/apps/mydb/elements/details/cellLines/propertiesTab/GeneralProperties.js
Outdated
Show resolved
Hide resolved
| ]; | ||
| const { item } = this.props; | ||
| const { currentUser } = UserStore.getState(); | ||
| if (item.created_by == null) { |
There was a problem hiding this comment.
Couldn't this guard be removed if the cell line (item) is instantiated with (created_by = '') in CellLine.buildEmpty()?
There was a problem hiding this comment.
No. Tested it and it doesn't work when creating celllines.
PiTrem
reviewed
Mar 10, 2025
PiTrem
added a commit
that referenced
this pull request
Mar 11, 2025
Squashed commit of the following: commit 44b54e8 Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Tue Mar 11 08:13:08 2025 +0000 review findings commit a427fc3 Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Fri Feb 28 09:28:10 2025 +0000 refactor: rubocop & typo commit 5d32e53 Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Wed Feb 26 14:46:10 2025 +0000 feat: added column created_by and set access commit faf855e Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Wed Feb 26 10:04:43 2025 +0000 fix: tests because of index commit 03b432c Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Fri Feb 21 11:37:14 2025 +0000 added index on (name, source) in cellline_materials
PiTrem
added a commit
that referenced
this pull request
Mar 12, 2025
Squashed commit of the following: commit 44b54e8 Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Tue Mar 11 08:13:08 2025 +0000 review findings commit a427fc3 Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Fri Feb 28 09:28:10 2025 +0000 refactor: rubocop & typo commit 5d32e53 Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Wed Feb 26 14:46:10 2025 +0000 feat: added column created_by and set access commit faf855e Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Wed Feb 26 10:04:43 2025 +0000 fix: tests because of index commit 03b432c Author: Adrian Herrmann <adrian.herrmann@kit.edu> Date: Fri Feb 21 11:37:14 2025 +0000 added index on (name, source) in cellline_materials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Index on (name, source) to cellline_materials
Add column created_by to cellline_materials
Allow change only to creator