feat: added column created_by and set access

Author: Adrian Herrmann

app/api/helpers/cell_line_api_params_helpers.rb

@@ -34,6 +34,7 @@ module CellLineApiParamsHelpers
     optional :mutation, type: String, desc: 'mutation of a cell line'
     optional :description, type: String, desc: 'description of a cell line sample'
     optional :short_label, type: String, desc: 'short label of a cell line sample'
+    optional :created_by, type: Integer, desc: 'creator of cell line material'
     requires :container, type: Hash, desc: 'root Container of element'
   end
 

app/javascript/src/apps/mydb/elements/details/cellLines/propertiesTab/GeneralProperties.js

@@ -9,11 +9,29 @@ import PropTypes from 'prop-types';
 import CellLineName from 'src/apps/mydb/elements/details/cellLines/propertiesTab/CellLineName';
 import Amount from 'src/apps/mydb/elements/details/cellLines/propertiesTab/Amount';
 import InvalidPropertyWarning from 'src/apps/mydb/elements/details/cellLines/propertiesTab/InvalidPropertyWarning';
+import UserStore from 'src/stores/alt/stores/UserStore';
 
 class GeneralProperties extends React.Component {
   // eslint-disable-next-line react/static-property-placement
   static contextType = StoreContext;
 
+  // eslint-disable-next-line class-methods-use-this
+  checkPermission(attributeName) {
+    const readonlyAttributes = [
+      'Disease', 'Organism', 'Tissue', 'Growth medium', 'Mutation', 'Variant', 'Biosafety level',
+      'Cryopreservation medium', 'Opt. growth temperature', 'Gender', 'Cell type', 'Material Description'
+    ];
+    const { item } = this.props;
+    const { currentUser } = UserStore.getState();
+    if (item.created_by == null) {
+      const { cellLineDetailsStore } = this.context;
+      const cellLine = cellLineDetailsStore.cellLines(item.id);
+      return readonlyAttributes.includes(attributeName)
+        && cellLine.created_by !== '' && cellLine.created_by !== currentUser.id.toString();
+    }
+    return readonlyAttributes.includes(attributeName) && item.created_by !== currentUser.id;
+  }
+
   renderOptionalAttribute(attributeName, defaultValue, onChangeCallBack) {
     return this.renderAttribute(attributeName, defaultValue, onChangeCallBack, true);
   }
@@ -43,7 +61,7 @@ class GeneralProperties extends React.Component {
         <Form.Label column sm={3}>{attributeName}</Form.Label>
         <Col sm={9}>
           <Form.Control
-            disabled={readOnly}
+            disabled={readOnly || this.checkPermission(attributeName)}
             className={styleClass}
             type="text"
             value={defaultValue}
@@ -69,10 +87,10 @@ class GeneralProperties extends React.Component {
         <Form.Label column sm={3}>Biosafety level</Form.Label>
         <Col sm={9}>
           <Select
-            isDisabled={readOnly}
+            isDisabled={readOnly || this.checkPermission('Biosafety level')}
             options={options}
             isClearable={false}
-            value={options.find(({value}) => value === item.bioSafetyLevel)}
+            value={options.find(({ value }) => value === item.bioSafetyLevel)}
             onChange={(e) => { cellLineDetailsStore.changeBioSafetyLevel(item.id, e.value); }}
           />
         </Col>
@@ -117,7 +135,7 @@ class GeneralProperties extends React.Component {
           <Amount
             cellLineId={item.id}
             initialValue={item.amount}
-            readOnly={readOnly}
+            readOnly={readOnly || this.checkPermission('Amount')}
           />
         </Col>
         <Col sm={3} className="amount-unit">
@@ -187,7 +205,7 @@ class GeneralProperties extends React.Component {
             {this.renderOptionalAttribute('Cell type', cellLineItem.cellType, (e) => {
               cellLineDetailsStore.changeCellType(cellLineId, e.target.value);
             })}
-            {this.renderOptionalAttribute('Description', cellLineItem.materialDescription, (e) => {
+            {this.renderOptionalAttribute('Material Description', cellLineItem.materialDescription, (e) => {
               cellLineDetailsStore.changeMaterialDescription(cellLineId, e.target.value);
             })}
           </Accordion.Body>
@@ -209,7 +227,7 @@ class GeneralProperties extends React.Component {
             {this.renderOptionalAttribute('Name of specific probe', cellLineItem.itemName, (e) => {
               cellLineDetailsStore.changeItemName(cellLineId, e.target.value);
             })}
-            {this.renderOptionalAttribute('Description', cellLineItem.itemDescription, (e) => {
+            {this.renderOptionalAttribute('Sample Description', cellLineItem.itemDescription, (e) => {
               cellLineDetailsStore.changeItemDescription(cellLineId, e.target.value);
             })}
           </Accordion.Body>
@@ -224,6 +242,8 @@ export default observer(GeneralProperties);
 GeneralProperties.propTypes = {
   readOnly: PropTypes.bool.isRequired,
   item: PropTypes.shape({
-    id: PropTypes.string.isRequired
+    id: PropTypes.string.isRequired,
+    can_update: PropTypes.bool,
+    created_by: PropTypes.number
   }).isRequired
 };

app/javascript/src/models/cellLine/CellLine.js

@@ -45,6 +45,7 @@ export default class CellLine extends Element {
     cellLine.cellType = response.cellline_material.cell_type;
     cellLine.bioSafetyLevel = response.cellline_material.biosafety_level;
     cellLine.cryopreservationMedium = response.cellline_material.cryo_pres_medium;
+    cellLine.created_by = response.cellline_material.created_by;
     cellLine.is_new = false;
 
     cellLine.container = response.container;
@@ -67,6 +68,7 @@ export default class CellLine extends Element {
     this.gender = cellLineItem.gender;
     this.materialDescription = cellLineItem.materialDescription;
     this.source = cellLineItem.source;
+    this.created_by = cellLineItem.created_by;
   }
 
   adoptPropsFromMobXModel(mobx) {
@@ -91,5 +93,6 @@ export default class CellLine extends Element {
     this.bioSafetyLevel = mobx.bioSafetyLevel;
     this.cellType = mobx.cellType;
     this.cryopreservationMedium = mobx.cryopreservationMedium;
+    this.created_by = mobx.created_by;
   }
 }

app/javascript/src/stores/mobx/CellLineDetailsStore.jsx

@@ -44,6 +44,7 @@ const CellLineItem = types
     growthMedium: '',
     itemDescription: '',
     itemName: '',
+    created_by: '',
     changed: false
   }).views((self) => ({
     isAmountValid() {
@@ -165,6 +166,7 @@ export const CellLineDetailsStore = types
       item.mutation = properties.mutation;
       item.source = properties.source;
       item.growthMedium = properties.growth_medium;
+      item.created_by = properties.created_by?.toString();
     },
     convertJsModelToMobxModel(container) {
       return CellLineAnalysis.create({
@@ -203,6 +205,7 @@ export const CellLineDetailsStore = types
         growthMedium: jsCellLineModel.growthMedium,
         itemName: jsCellLineModel.itemName,
         shortLabel: jsCellLineModel.short_label,
+        created_by: jsCellLineModel.created_by?.toString(),
       }));
     }
   }))

app/models/cellline_material.rb

@@ -22,6 +22,7 @@
 #  deleted_at          :datetime
 #  created_at          :datetime         not null
 #  updated_at          :datetime         not null
+#  created_by          :integer
 #
 class CelllineMaterial < ApplicationRecord
   acts_as_paranoid

app/usecases/cell_lines/create.rb

@@ -45,6 +45,7 @@ def create_cellline_material
           cryo_pres_medium: @params[:cryo_pres_medium],
           gender: @params[:gender],
           description: @params[:material_description],
+          created_by: @current_user.id,
         )
       end
 

app/usecases/cell_lines/update.rb

@@ -16,7 +16,10 @@ def execute!
 
         @cell_line_sample.cellline_material = find_material || create_new_material
         update_sample_properties
-        update_material_properties(@cell_line_sample.cellline_material)
+        if @cell_line_sample.cellline_material.created_by.nil? ||
+           @cell_line_sample.cellline_material.created_by == @current_user.id
+          update_material_properties(@cell_line_sample.cellline_material)
+        end
         @cell_line_sample.save
         @cell_line_sample
       end

db/migrate/20250221105051_cell_lines_constraint.rb

@@ -0,0 +1,8 @@
+# frozen_string_literal: true
+
+class AddColumnToCelllineMaterial < ActiveRecord::Migration[6.1]
+  def change
+    add_index :cellline_materials, %i[name source], unique: true
+    add_column :cellline_materials, :created_by, :integer, null: true
+  end
+end

db/migrate/20250226095051_add_column_to_cellline_material.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2025_02_21_105051) do
+ActiveRecord::Schema.define(version: 2025_02_26_095051) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "hstore"
@@ -131,6 +131,7 @@
     t.datetime "deleted_at"
     t.datetime "created_at", precision: 6, null: false
     t.datetime "updated_at", precision: 6, null: false
+    t.integer "created_by"
     t.index ["name", "source"], name: "index_cellline_materials_on_name_and_source", unique: true
   end