Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Ensure clear_auth_cookie uses the correct secure and samesite settings #1959

Merged
merged 3 commits into from
Mar 7, 2025
Merged

Fix: Ensure clear_auth_cookie uses the correct secure and samesite settings #1959

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf24661
Update cookie.py - Ensure clear_auth_cookie uses correct secure and s…
ilkertuna Mar 5, 2025
19471a9
Update cookie.py
ilkertuna Mar 7, 2025
157344f
Merge branch 'main' into main
ilkertuna Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions backend/chainlit/auth/cookie.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,12 @@ def set_auth_cookie(request: Request, response: Response, token: str):

# Delete remaining prior cookies/cookie chunks
for k in existing_cookies:
response.delete_cookie(key=k, path="/")
response.delete_cookie(
key=k,
path="/",
secure=_cookie_secure,
samesite=_cookie_samesite
)


def clear_auth_cookie(request: Request, response: Response):
Expand All @@ -162,7 +167,12 @@ def clear_auth_cookie(request: Request, response: Response):
}

for k in existing_cookies:
response.delete_cookie(key=k, path="/")
response.delete_cookie(
key=k,
path="/",
secure=_cookie_secure,
samesite=_cookie_samesite
)


def set_oauth_state_cookie(response: Response, token: str):
Expand Down
Loading