Fix: Ensure clear_auth_cookie uses the correct secure and samesite settings #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amesite settings Ensure clear_auth_cookie uses correct secure and samesite settings clear_auth_cookie was not explicitly specifying the secure and samesite attributes when deleting cookies. This could cause logout issues if CHAINLIT_COOKIE_SAMESITE was set to a custom value. Now, clear_auth_cookie applies the same secure and samesite settings as set_auth_cookie to ensure consistent behavior.
dosubot
bot
added
size:S
ilkertuna
changed the title
|
Please run |
fix format
dosubot
bot
added
size:XS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where
clear_auth_cookiedid not explicitly specify thesecureandsamesiteattributes when deleting authentication cookies.Issue:
set_auth_cookiefunction correctly sets cookies using the_cookie_secureand_cookie_samesitevalues.CHAINLIT_COOKIE_SAMESITE.CHAINLIT_COOKIE_SAMESITEis"none", then_cookie_secureis set toTrue, ensuring the cookie is only sent over HTTPS._cookie_secureisFalse.clear_auth_cookiedid not apply these settings when deleting cookies.CHAINLIT_COOKIE_SAMESITEto a value other than the default ("lax"), the logout process could fail because the browser might not clear the cookie correctly.Fix:
clear_auth_cookienow ensures that cookies are deleted using the samesecureandsamesitesettings asset_auth_cookie.This change improves consistency and ensures proper authentication cleanup across different deployment environments.