fix: improve sync committee updates #7456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #7456 +/- ##
============================================
+ Coverage 50.25% 50.44% +0.19%
============================================
Files 602 602
Lines 40401 40583 +182
Branches 2204 2229 +25
============================================
+ Hits 20305 20474 +169
- Misses 20056 20069 +13
Partials 40 40 |
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
|
posting benchmark from my personal ubuntu node which is the same to it also shows >1000x improvement for some tests, similar to my local environment |
wemeetagain
previously approved these changes
Feb 12, 2025
wemeetagain
previously approved these changes
Feb 12, 2025
|
|
||
| let i = 0; | ||
| let cachedHash: Uint8Array | null = null; | ||
| const cachedHashInput = Buffer.allocUnsafe(32 + 8); |
There was a problem hiding this comment.
added: reuse this buffer as the input for digest below
| @@ -120,6 +120,8 @@ export function computeProposerIndex( | |||
| const shuffledResult = new Map<number, number>(); | |||
|
|
|||
| let i = 0; | |||
| const cachedHashInput = Buffer.allocUnsafe(32 + 8); | |||
There was a problem hiding this comment.
added: reuse this buffer as the input for digest below
| @@ -402,7 +408,7 @@ export function getComputeShuffledIndexFn(indexCount: number, seed: Bytes32): Co | |||
| // bytesToBigInt(digest(Buffer.concat([_seed, intToBytes(i, 1)])).slice(0, 8)) % BigInt(indexCount) | |||
| // ); | |||
| pivotBuffer[32] = i % 256; | |||
| pivot = Number(bytesToBigInt(digest(pivotBuffer).slice(0, 8)) % BigInt(indexCount)); | |||
| pivot = Number(bytesToBigInt(digest(pivotBuffer).subarray(0, 8)) % BigInt(indexCount)); | |||
There was a problem hiding this comment.
added: use subarray instead of slice
wemeetagain
approved these changes
Feb 12, 2025
2 tasks
|
🎉 This PR is included in v1.27.0 🎉 |
|
GG 👏 |
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
processSyncCommitteeUpdates()could be >15s according to the devnetDescription
computeShuffledIndexwhere we can cache pivot and source computation therebytesToIntin order not to use BigIntI guess if we use
hashtreewe can improve more but the diff is a lot already and the main optimization is incomputeShuffledIndex(), not the hash function. We can consider that in the future.We can also improve pre-electra but I think it's been not that bad for a long time, so only focus on electra in this PR
Closes #7366
Tests
naiveGetNextSyncCommitteeIndices()while CI only show >20x difference. This is my local