Fix MSSQL tests. #15639
Merged
Fix MSSQL tests. #15639
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
mike12345567
approved these changes
Feb 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A while ago we hit a problem where our
mssqlDocker container would fail to run on Linux kernel version 6.8.0, which was the kernel used onubuntu-latestat the time. So we pinned toubuntu-22.04, which used kernel 6.5.0.ubuntu-22.04recently updated from 6.5.0 to 6.8.0 and as a result ourmssqltests have been failing. This PR does a couple of things:ubuntu-24.04, which is also kernel 6.8.0, seeing as we don't have any other reason to pin to an older runner.mssqlimage from 2019 to 2022, as this newer version runs successfully on 6.8.0.mssqlcontainer healthchecks to support that TLS is now on by default and the location of the tool we use to do the healthchecking has moved.