Skip to content

Commit a1910a8

Browse files
authored
Merge pull request #15639 from Budibase/debug-testcontainers
Fix MSSQL tests.
2 parents d6d32ce + a684c9f commit a1910a8

File tree

3 files changed

+12
-11
lines changed

3 files changed

+12
-11
lines changed

.github/workflows/budibase_ci.yml

+8-8
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ env:
3030

3131
jobs:
3232
lint:
33-
runs-on: ubuntu-22.04
33+
runs-on: ubuntu-24.04
3434
steps:
3535
- name: Checkout repo
3636
uses: actions/checkout@v4
@@ -47,7 +47,7 @@ jobs:
4747
- run: yarn lint
4848

4949
build:
50-
runs-on: ubuntu-22.04
50+
runs-on: ubuntu-24.04
5151
steps:
5252
- name: Checkout repo
5353
uses: actions/checkout@v4
@@ -76,7 +76,7 @@ jobs:
7676
fi
7777
7878
helm-lint:
79-
runs-on: ubuntu-22.04
79+
runs-on: ubuntu-24.04
8080
steps:
8181
- name: Checkout repo
8282
uses: actions/checkout@v4
@@ -88,7 +88,7 @@ jobs:
8888
- run: cd charts/budibase && helm lint .
8989

9090
test-libraries:
91-
runs-on: ubuntu-22.04
91+
runs-on: ubuntu-24.04
9292
steps:
9393
- name: Checkout repo
9494
uses: actions/checkout@v4
@@ -122,7 +122,7 @@ jobs:
122122
fi
123123
124124
test-worker:
125-
runs-on: ubuntu-22.04
125+
runs-on: ubuntu-24.04
126126
steps:
127127
- name: Checkout repo
128128
uses: actions/checkout@v4
@@ -151,7 +151,7 @@ jobs:
151151
yarn test --verbose --reporters=default --reporters=github-actions
152152
153153
test-server:
154-
runs-on: ubuntu-22.04
154+
runs-on: ubuntu-24.04
155155
strategy:
156156
matrix:
157157
datasource:
@@ -253,7 +253,7 @@ jobs:
253253
yarn test --filter $FILTER --verbose --reporters=default --reporters=github-actions
254254
255255
check-pro-submodule:
256-
runs-on: ubuntu-22.04
256+
runs-on: ubuntu-24.04
257257
if: inputs.run_as_oss != true && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'Budibase/budibase')
258258
steps:
259259
- name: Checkout repo and submodules
@@ -312,7 +312,7 @@ jobs:
312312
fi
313313
314314
check-lockfile:
315-
runs-on: ubuntu-22.04
315+
runs-on: ubuntu-24.04
316316
if: inputs.run_as_oss != true && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == 'Budibase/budibase')
317317
steps:
318318
- name: Checkout repo

packages/server/datasource-sha.env

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
MSSQL_SHA=sha256:3b913841850a4d57fcfcb798be06acc88ea0f2acc5418bc0c140a43e91c4a545
1+
MSSQL_SHA=sha256:d252932ef839c24c61c1139cc98f69c85ca774fa7c6bfaaa0015b7eb02b9dc87
22
MYSQL_SHA=sha256:9de9d54fecee6253130e65154b930978b1fcc336bcc86dfd06e89b72a2588ebe
33
POSTGRES_SHA=sha256:bd0d8e485d1aca439d39e5ea99b931160bd28d862e74c786f7508e9d0053090e
44
MONGODB_SHA=sha256:afa36bca12295b5f9dae68a493c706113922bdab520e901bd5d6c9d7247a1d8d

packages/server/src/integrations/tests/utils/mssql.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export async function getDatasource(): Promise<Datasource> {
2323
})
2424
.withWaitStrategy(
2525
Wait.forSuccessfulCommand(
26-
"/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P Password_123 -q 'SELECT 1'"
26+
"/opt/mssql-tools18/bin/sqlcmd -C -S localhost -U sa -P Password_123 -q 'SELECT 1'"
2727
).withStartupTimeout(20000)
2828
)
2929
)
@@ -44,7 +44,8 @@ export async function getDatasource(): Promise<Datasource> {
4444
user: "sa",
4545
password: "Password_123",
4646
options: {
47-
encrypt: false,
47+
encrypt: true,
48+
trustServerCertificate: true,
4849
},
4950
},
5051
}

0 commit comments

Comments
 (0)