Add test for BI-2057. #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add page for Sample Management. Add steps for Sample Management.
cvacalares
requested review from
a team,
davedrp and
nickpalladino
and removed request for
a team
|
Still working on it. |
nickpalladino
approved these changes
Sep 4, 2024
|
@davedrp - i have included the genotype samples. please review. thanks. |
davedrp
requested changes
Sep 6, 2024
src/features/BI-2057.feature
Outdated
| When user sets "GermplasmSort" in List Name field of import page | ||
| When user sets "GermplasmSort" in List Description field of import page | ||
| And user selects "Confirm" button | ||
| When user selects "Experiments & Observations" in navigation |
There was a problem hiding this comment.
I don't think you need to import on experiment (bi_sample_submission.xls only references GID, not ObsUnitID).
I think you should be able to delete these 5-lines:
When user selects "Experiments & Observations" in navigation
When user selects "Import Experiments & Observations" button
And user uploads Experiments & Observations "EXP.csv" file
When user selects 'Import' button
And user selects "Confirm" button
There was a problem hiding this comment.
@davedrp - Done. thanks.
davedrp
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BI-2057
Add page for Sample Management.
Add steps for Sample Management.
Dependencies
Please include any dependencies to other code branches, testing configurations, scripts to be run, etc.
Testing
Please include a link to a successful run of TAF for this change
Checklist: