This repository was archived by the owner on Feb 26, 2025. It is now read-only.
don't use exceptions when non-exceptional methods are available #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matz-e
reviewed
Mar 8, 2022
matz-e
approved these changes
Mar 16, 2022
mgeplf
commented
Mar 16, 2022
| @@ -163,67 +227,4 @@ breadth_iterator Morphology::breadth_end() const { | |||
| return breadth_iterator(); | |||
| } | |||
|
|
|||
| SomaType getSomaType(long unsigned int num_soma_points) { | |||
| try { | |||
There was a problem hiding this comment.
moved to anonymous namespace and replaced the try w/ a switch
mgeplf
commented
Mar 16, 2022
src/morphology.cpp
Outdated
| return morphio::SOMA_SINGLE_POINT; | ||
| case 2: | ||
| return morphio::SOMA_UNDEFINED; | ||
| default:; |
There was a problem hiding this comment.
this is how clang-format wanted this; FYI
There was a problem hiding this comment.
One could fold the return below into the switch, but maybe some other linting thing then complains?
eleftherioszisis
approved these changes
Mar 18, 2022
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.