code review feedback, some cleanup

BlueBrain · Mar 16, 2022 · c65fdff · c65fdff
1 parent f0785ab
commit c65fdff
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/include/morphio/morphology.h b/include/morphio/morphology.h
@@ -43,7 +43,7 @@ class Morphology
     /** Constructor from an already parsed file */
     explicit Morphology(const HighFive::Group& group, unsigned int options = NO_MODIFIER);
     /** Constructor from an instance of morphio::mut::Morphology */
-    explicit Morphology(mut::Morphology);
+    explicit Morphology(const mut::Morphology&);
 
     /** Return the soma object */
     Soma soma() const;
@@ -52,7 +52,7 @@ class Morphology
     Mitochondria mitochondria() const;
 
     /** Return the endoplasmic reticulum object */
-    const EndoplasmicReticulum endoplasmicReticulum() const;
+    EndoplasmicReticulum endoplasmicReticulum() const;
 
     /** Return the annotation object */
     const std::vector<Property::Annotation>& annotations() const;

diff --git a/include/morphio/section_base.h b/include/morphio/section_base.h
@@ -124,7 +124,7 @@ T SectionBase<T>::parent() const {
 
 template <typename T>
 std::vector<T> SectionBase<T>::children() const {
-    const auto section_children = properties_->children<typename T::SectionId>();
+    const auto& section_children = properties_->children<typename T::SectionId>();
 
     if (section_children.empty()) {
         return {};

diff --git a/src/morphology.cpp b/src/morphology.cpp
@@ -106,7 +106,7 @@ Morphology::Morphology(const HighFive::Group& group, unsigned int options)
 Morphology::Morphology(const std::string& source, unsigned int options)
     : Morphology(loadURI(source, options), options) {}
 
-Morphology::Morphology(mut::Morphology morphology) {
+Morphology::Morphology(const mut::Morphology& morphology) {
     properties_ = std::make_shared<Property::Properties>(morphology.buildReadOnly());
     buildChildren(properties_);
 }
@@ -119,7 +119,7 @@ Mitochondria Morphology::mitochondria() const {
     return Mitochondria(properties_);
 }
 
-const EndoplasmicReticulum Morphology::endoplasmicReticulum() const {
+EndoplasmicReticulum Morphology::endoplasmicReticulum() const {
     return EndoplasmicReticulum(properties_);
 }
 
@@ -136,7 +136,7 @@ Section Morphology::section(uint32_t id) const {
 }
 
 std::vector<Section> Morphology::rootSections() const {
-    const auto sections = properties_->children<morphio::Property::Section>();
+    const auto& sections = properties_->children<morphio::Property::Section>();
 
     if (sections.empty()) {
         return {};