Updating fork. #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating rxjs. * Adding require reflect-metadata. * Adding new lines at the end for tslinter.
* Correctly reading current command in shared Karma config * Added comment
* added localization and testing to the helpwidget locale * created a constant for the skyuxHost
* trying to bypass some stuff * overriding some methods for testing * workring on changes to configs and cli commands. Still need to get config and tokenProvider to be overriden * dynamically adding pact ports * adding more karma config settings, adding a service for use my consuming apps, and a util to help with passing information to user in AppConfig * Adding documentation, watch option for command, and making interface for pact settings in config file * supporting looking for only pact-spec files * respecting a bunch of jslint errors when running npm run test * optionally let use define directory for pact json and pact logs * changing import statement * formatting changes and moving dynamically set config settings to runtime * karma-pact depends on the latest pact-node, but our config doesn't ensure the latest is updated. * letting karma-pact take care of it's pact-node dependency. Still need pact as the DSL and pact-web * cleaning up some formatting so build passes * noticed ports weren't being retreived across processes. portfinder doesn't look at host 0:0:0:0 and also promises need to be resolved sequentially to prevent promises resolving on same port since they don't get consumed until after portfinder starts. * adding spec file for pacts * writing tests for pact command, made some changes based on my findings during testing. * tests on karma config, and further changes for thing found during testing * for whatever reason, not including this causes errors. * 100% coverage * some linting errors getting fixed * removing that one extra line * thinking not stopping all mocks here could've caused the issue * weird merge conflict that didn't cause build to fail, and removing carats from package.json * possibly no need to have the pact-web package * right, this test needs to be updated
* things * e2e tests for help widget * comment to explain the test in case it breaks in the future, this will enable easier debugging * race condition * added comments for clarity * template spacing * removed fdescribe * class name and comment updates * line breaks for comment * using fs-extra * removed async import * combine final param into one, updated with master
…and can be passed through to plugins (#351) * Removed process.exit(0) from generate() module the generate command can be passed through to plugins * Updated unit test to reflect new logic
* trying to bypass some stuff * overriding some methods for testing * workring on changes to configs and cli commands. Still need to get config and tokenProvider to be overriden * dynamically adding pact ports * adding more karma config settings, adding a service for use my consuming apps, and a util to help with passing information to user in AppConfig * Adding documentation, watch option for command, and making interface for pact settings in config file * supporting looking for only pact-spec files * respecting a bunch of jslint errors when running npm run test * optionally let use define directory for pact json and pact logs * changing import statement * formatting changes and moving dynamically set config settings to runtime * karma-pact depends on the latest pact-node, but our config doesn't ensure the latest is updated. * letting karma-pact take care of it's pact-node dependency. Still need pact as the DSL and pact-web * cleaning up some formatting so build passes * noticed ports weren't being retreived across processes. portfinder doesn't look at host 0:0:0:0 and also promises need to be resolved sequentially to prevent promises resolving on same port since they don't get consumed until after portfinder starts. * adding spec file for pacts * writing tests for pact command, made some changes based on my findings during testing. * tests on karma config, and further changes for thing found during testing * for whatever reason, not including this causes errors. * 100% coverage * some linting errors getting fixed * removing that one extra line * thinking not stopping all mocks here could've caused the issue * weird merge conflict that didn't cause build to fail, and removing carats from package.json * possibly no need to have the pact-web package * right, this test needs to be updated * package change * updating packing to hard define dependencies * updating again * that version didn't exist in @pact-foundation * last stable release * last known working config * updating config to allow for parallel testing, and only adding single package. Letting it handle it's own dependencies * adding necessary dependencies for a working model. Updating service to include matchers and adding new property to pact object to allow control over write mode. * despite example showing use of PactWeb, this apparently is not a function * need to require pact-web and changing how it's referenced in pact karma.config. Finally adding matchers. * updating package.json * updating test * updating packages so all are under @pact-foundation scope. Ensuring config looks in correct directory * final necessary update * update test and lint issues
* Initial commit of skyuxconfig.json schema * Allowing $schema property * Added codeCoverageThreshold * Removing schema property
…ith a permission scope (#498)
…eck (#499) * Use the remapped code coverage summary for code coverage threshold check * Fixed lint rule * Unit tests * Removed redundant const * Validate that done() called * Be explicit about whether test should pass coverage threshold check * Fixed lint error * Report coverage inside _onWriteReport() since _onExit() doesn't get called during `watch` * Minor refactoring * Fixed linting error. * Use function expression for consistency * Changed `let` to`const` where appropriate
…/-f to bypass. (#500) * Checking if files exists before writing in generate. Allowing force to bypass. * Allowing shortcut force. * Fixed linting error. * Fixed linting suggestions.
* Updated CHANGELOG.md and package.json for 1.31.0 * Wording tweak and missing period
* Using a fork of webpack-dev-server * Doc tweaks
* Fix moduleAliases to work with builds * Fixed unit tests
* Removed references to http-server. * Allowing custom path. Added test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.