This repository was archived by the owner on Dec 8, 2022. It is now read-only.
Initial commit of skyuxconfig.json schema #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-BobbyEarl
changed the title
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 71 71
Lines 1685 1685
Branches 264 264
=======================================
Hits 1672 1672
Misses 13 13
Continue to review full report at Codecov.
|
Blackbaud-BobbyEarl
changed the title
|
Hey @Blackbaud-PaulCrowder and @Blackbaud-SteveBrush, this is ready to talk-through whenever we have time. |
added 2 commits
January 23, 2018 16:44
…er into skyuxconfig-schema
Blackbaud-BobbyEarl
requested review from
Blackbaud-PaulCrowder and
Blackbaud-SteveBrush
Blackbaud-PaulCrowder
approved these changes
Jan 24, 2018
Blackbaud-MikitaYankouski
pushed a commit
to Blackbaud-MikitaYankouski/skyux-builder
that referenced
this pull request
May 3, 2019
* Initial commit of skyuxconfig.json schema * Allowing $schema property * Added codeCoverageThreshold * Removing schema property
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users would need to add the following to their
skyuxconfig.jsonfiles:Update
Instead, I'll be creating a PR to https://github.com/schemastore/schemastore/. I have a PR ready to submit via SchemaStore/schemastore@master...Blackbaud-BobbyEarl:skyuxconfig-initial-commit, but will need this PR merged in first.
Reason being, I chose to point the catalog URL to this file directly (as opposed to using their site). This is the same approach the Angular CLI has used. I think it will all us to make changes internally without having to submit a duplicate PR to them.