Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the broken it #266

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: fix the broken it #266

merged 1 commit into from
Feb 19, 2025

Conversation

zhiying-lin
Copy link
Contributor

What type of PR is this?

/kind bug
/kind test

What this PR does / why we need it:
The IT was broken because of merging #261 and #263 at the same time.

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.60%. Comparing base (1db34bd) to head (0b44951).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   79.51%   79.60%   +0.09%     
==========================================
  Files          28       28              
  Lines        3973     3976       +3     
==========================================
+ Hits         3159     3165       +6     
+ Misses        652      650       -2     
+ Partials      162      161       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@michaelawyu michaelawyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ;)

@michaelawyu michaelawyu merged commit 676efec into Azure:main Feb 19, 2025
10 checks passed
@zhiying-lin zhiying-lin deleted the fix-it branch February 20, 2025 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants