Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support weight 0 serviceExport #261

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

zhiying-lin
Copy link
Contributor

@zhiying-lin zhiying-lin commented Feb 13, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • support weight 0
  • fix a bug in the internalServiceExport controller
  • fix the error message when the public ip is not ready
  • reduce the e2e test flakiness by increasing the eventually timeout

Which issue(s) this PR fixes:

Fixes #

Requirements:

How has this code been tested

Special notes for your reviewer

@zhiying-lin zhiying-lin marked this pull request as draft February 13, 2025 10:46
@zhiying-lin zhiying-lin force-pushed the support-weight-0 branch 2 times, most recently from 182cfaf to 0a07ebc Compare February 18, 2025 12:08
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.58%. Comparing base (29d2d8a) to head (1e29f37).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/member/serviceexport/controller.go 84.61% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
+ Coverage   79.49%   79.58%   +0.09%     
==========================================
  Files          28       28              
  Lines        3936     3973      +37     
==========================================
+ Hits         3129     3162      +33     
- Misses        647      650       +3     
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhiying-lin zhiying-lin marked this pull request as ready for review February 18, 2025 13:46
@ryanzhang-oss ryanzhang-oss merged commit 1db34bd into Azure:main Feb 19, 2025
14 checks passed
@zhiying-lin zhiying-lin deleted the support-weight-0 branch February 19, 2025 09:17
@zhiying-lin zhiying-lin mentioned this pull request Feb 19, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants