Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pedersen compression of vk data #259

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Pedersen compression of vk data #259

merged 4 commits into from
Mar 23, 2023

Conversation

dbanks12
Copy link
Contributor

@dbanks12 dbanks12 commented Mar 22, 2023 •
edited by suyash67
Loading

Description

Pedersen compression of vk data

also resolves #261

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • There are no circuit changes, OR specifications in /markdown/specs have been updated.
  • There are no circuit changes, OR a cryptographer has been assigned for review.
  • I've updated any terraform that needs updating (e.g. environment variables) for deployment.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.

@dbanks12 dbanks12 requested a review from suyash67 March 22, 2023 19:52
@dbanks12 dbanks12 mentioned this pull request Mar 22, 2023
Merged
11 tasks
ludamad
ludamad approved these changes Mar 23, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although no clue on crypto correctness

@suyash67 suyash67 force-pushed the db/vk_data_compress branch from 92303c3 to 362caae Compare March 23, 2023 22:01
@suyash67 suyash67 force-pushed the db/vk_data_compress branch from 362caae to ef931c6 Compare March 23, 2023 22:26
@suyash67 suyash67 merged commit ce0673f into aztec3 Mar 23, 2023
@suyash67 suyash67 deleted the db/vk_data_compress branch March 23, 2023 22:26
suyash67 added a commit that referenced this pull request Mar 29, 2023
@dbanks12 @suyash67
Pedersen compression of vk data (#259)
800534d 
* pedersen compression of vk data

* Add `composer_type` while hashing/compressing a vkey.

* js vk fix.

* Fix js vk (again?)

---------

Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>
suyash67 added a commit that referenced this pull request Apr 5, 2023
@dbanks12 @suyash67
Pedersen compression of vk data (#259)
676d65e 
* pedersen compression of vk data

* Add `composer_type` while hashing/compressing a vkey.

* js vk fix.

* Fix js vk (again?)

---------

Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>
suyash67 added a commit that referenced this pull request Apr 6, 2023
@dbanks12 @suyash67
Pedersen compression of vk data (#259)
6f3d785 
* pedersen compression of vk data

* Add `composer_type` while hashing/compressing a vkey.

* js vk fix.

* Fix js vk (again?)

---------

Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>
codygunton pushed a commit that referenced this pull request Apr 6, 2023
@dbanks12 @suyash67 @codygunton
Pedersen compression of vk data (#259)
0b7b72a 
* pedersen compression of vk data

* Add `composer_type` while hashing/compressing a vkey.

* js vk fix.

* Fix js vk (again?)

---------

Co-authored-by: Suyash Bagad <suyashnbagad1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

@suyash67 suyash67 suyash67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbanks12 @ludamad @suyash67