Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VK hash (sha256) should include the composer_type #261

Closed
dbanks12 opened this issue Mar 22, 2023 · 3 comments
Closed

VK hash (sha256) should include the composer_type #261

dbanks12 opened this issue Mar 22, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@dbanks12
Copy link
Contributor

I asked @suyash67 if composer_type be a part of a VK's hash as it is not included in the sha256. His answer was yes or at least probably yes.

@dbanks12 dbanks12 added the bug Something isn't working label Mar 22, 2023
@suyash67
Copy link
Contributor

Yes, I think we should add composer_type.

Imagine if we have two circuits with the exact same configuration, therefore same commitments, circuit_size, num_public_inputs but both use different underlying proof systems (stdhonk and stdplonk for example). In such a case, we would like the vk hash to make the distinction that both circuits are different.

@suyash67
Copy link
Contributor

Talked to Zac to confirm this. Zac suggested that we should even add some identifier of chain (for e.g. sha256("AZTEC_ETHEREUM")) so that the verification for same circuits across chains could also be unique. But we can do that later.

@codygunton
Copy link
Collaborator

This was done at some point. Cf #562 -- not sure this is a Barretenberg thing, and I'd like to get rid of various identification enums in favor of using the type system, functions like std::same_as, and derived concepts like HasPlookup and IsPlonkFlavor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants