fix: Enforce no import side effects #12268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we enabled `verbatimModuleSyntax` in yarn project, all imports of
the like `import { type Foo } from './foo.js'` now cause `foo.js` to be
actually imported in runtime. To prevent this, the `type` modifier needs
to be moved out of the braces. This is what this eslint rule does.
See [this post](https://typescript-eslint.io/blog/consistent-type-imports-and-exports-why-and-how/#verbatim-module-syntax) for more info.
spalladino
commented
Feb 25, 2025
| @@ -34,6 +34,7 @@ module.exports = { | |||
| node: true, | |||
| }, | |||
| rules: { | |||
| '@typescript-eslint/no-import-type-side-effects': 'error', | |||
There was a problem hiding this comment.
This is the only actualy change from this PR. This, and running lint --fix.
There was a problem hiding this comment.
And now the 2nd commit as well
ludamad
approved these changes
Feb 25, 2025
TomAFrench
added a commit
that referenced
this pull request
Feb 26, 2025
* master: (92 commits) chore: Log prover publisher address on creation (#12267) feat: https for bootnode in devnet (#12161) feat(avm): support shifts in lookups (#12280) feat(docs): Add flamegraph tool to counter contract tutorial (#12202) feat(spartan): 192 node 1 tps - additional validator service (#12238) feat(avm): class id derivation (#12263) docs: Fees doc snippets and code snippets (#12229) refactor: proving cost in fee header (#12048) fix: prometheus scrapes itself in the cluster (#12277) feat: metrics (#12256) chore: cleanup stdlib internal imports (#12274) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Enforce no import side effects (#12268) refactor!: note interfaces (#12106) yolo undenoise tests feat: new transcript functionality to hash elements without including in proof (#12233) chore: remove gcloud metrics (#12265) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we enabled
verbatimModuleSyntaxin yarn project, all imports of the likeimport { type Foo } from './foo.js'now causefoo.jsto be actually imported in runtime. This caused some tests to fail, due to a types-only file innoir-typesbeing imported that jest didn't like (we also need to figure out why jest didn't like it). To prevent this, thetypemodifier needs to be moved out of the braces. This is what this eslint rule does.This should allow running tests after compiling with either
tscorswc, so we can go back to usingyarn tsc -b -wfor local development.See this post for more info.