feat: new transcript functionality to hash elements without including in proof #12233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… element being added to the proof data
lucasxia01
commented
Feb 25, 2025
| info("consumed: ", label, ": ", element); | ||
| } | ||
| #endif | ||
| BaseTranscript::consume_prover_element_frs(label, element_frs); |
There was a problem hiding this comment.
this function should probably be renamed
There was a problem hiding this comment.
renamed because this is adding data to the proof? if so then yeah, why not
ledwards2225
approved these changes
Feb 25, 2025
| @@ -350,6 +350,31 @@ template <typename TranscriptParams> class BaseTranscript { | |||
| return call_get_challenges(); | |||
| } | |||
|
|
|||
| /** | |||
| * @brief Adds an element to the transcript. | |||
There was a problem hiding this comment.
Can you update this description to mention that this doesn't implicitly add to the proof?
| info("consumed: ", label, ": ", element); | ||
| } | ||
| #endif | ||
| BaseTranscript::consume_prover_element_frs(label, element_frs); |
There was a problem hiding this comment.
renamed because this is adding data to the proof? if so then yeah, why not
| * @param label Human-readable name for the challenge. | ||
| * @param element Element to be added. | ||
| */ | ||
| template <class T> void consume_element(const std::string& label, const T& element) |
There was a problem hiding this comment.
Any reason why a more explicit name like add_to_hash_buffer() wouldn't be appropriate here?
There was a problem hiding this comment.
no, couldn't think of a better name at the time
TomAFrench
added a commit
that referenced
this pull request
Feb 26, 2025
* master: (92 commits) chore: Log prover publisher address on creation (#12267) feat: https for bootnode in devnet (#12161) feat(avm): support shifts in lookups (#12280) feat(docs): Add flamegraph tool to counter contract tutorial (#12202) feat(spartan): 192 node 1 tps - additional validator service (#12238) feat(avm): class id derivation (#12263) docs: Fees doc snippets and code snippets (#12229) refactor: proving cost in fee header (#12048) fix: prometheus scrapes itself in the cluster (#12277) feat: metrics (#12256) chore: cleanup stdlib internal imports (#12274) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Enforce no import side effects (#12268) refactor!: note interfaces (#12106) yolo undenoise tests feat: new transcript functionality to hash elements without including in proof (#12233) chore: remove gcloud metrics (#12265) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new public add_to_hash_buffer function to the transcript that adds elements to the current_round_data buffer without adding them to the proof_data. This will enable us to hash things without explicitly including it in the proof like vk data that needs to be Fiat-Shamired but doesn't need to be sent in the proof.