Remove Pro plan from top storage plan list

[claudiucelfilip]

Proposed Changes

This is a follow-up change for the Excessive disk space message changes added in #64388.
With reversion of the legacy plans, we'll want to allow users to upgrade from Pro plan, to other higher storage plans (ie. Business, eCommerce).
This PR removes the Pro plan from the top storage plan list.

Testing Instructions

• Have a Pro plan site
• Sandbox API and hack the sandbox to think that all sites have excessive disk usage

diff --git a/wp-content/lib/atomic/woa.php b/wp-content/lib/atomic/woa.php
index 987f3b35a..accb4928e 100644
--- a/wp-content/lib/atomic/woa.php
+++ b/wp-content/lib/atomic/woa.php
@@ -2269,6 +2269,7 @@ function woa_unsuspend( $blog_id ) {
  * @return bool If disk usage is excessive and the site should not be transferred.
  */
 function woa_is_space_used_excessive( $blog_id ) {
+       return true;
        // The value returned by get_space_used_bytes() excludes transcoded media files, but includes the original media.
        $disk_space_used = get_space_used_bytes( $blog_id );
        if ( $disk_space_used > 150 * GB_IN_BYTES ) {

• Visit http://calypso.localhost:3000/hosting-config/activate/<site> and try to transfer to atomic
• You should see this image, nugding you to purchase a plan with additional storage:

• Repeat this for a Business/eCommerce site
• You should see this image, telling you to contact support:

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-65a8dcdbdd1ef45810a817281a20fa045d7233b8

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:commit-65a8dcdbdd1ef45810a817281a20fa045d7233b8&env=jetpack

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~264 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +979 B  (+0.1%)      +45 B  (+0.0%)
entry-stepper               +578 B  (+0.0%)     +225 B  (+0.0%)
entry-login                 +149 B  (+0.0%)       +6 B  (+0.0%)
entry-gutenboarding         +149 B  (+0.0%)       +6 B  (+0.0%)
entry-domains-landing       +149 B  (+0.0%)       +6 B  (+0.0%)
entry-browsehappy           +149 B  (+0.2%)       +6 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~5643 bytes removed 📉 [gzipped])

name                            parsed_size           gzip_size
media                              -41200 B  (-2.1%)   -11581 B  (-2.3%)
signup                               +871 B  (+0.2%)      +13 B  (+0.0%)
jetpack-connect                      +871 B  (+0.1%)      -39 B  (-0.0%)
accept-invite                        +871 B  (+0.2%)      +13 B  (+0.0%)
home                                 +722 B  (+0.1%)     +360 B  (+0.2%)
migrate                              +711 B  (+0.2%)     +332 B  (+0.3%)
backup                               +427 B  (+0.0%)     +250 B  (+0.1%)
scan                                 +417 B  (+0.1%)     +251 B  (+0.1%)
earn                                 +402 B  (+0.1%)     +212 B  (+0.1%)
themes                               +374 B  (+0.1%)     +215 B  (+0.1%)
settings-performance                 +319 B  (+0.1%)     +190 B  (+0.1%)
checkout                             +314 B  (+0.0%)     +124 B  (+0.0%)
hosting                              +303 B  (+0.1%)     +171 B  (+0.1%)
plugins                              +293 B  (+0.0%)     +171 B  (+0.1%)
domains                              -265 B  (-0.0%)      +82 B  (+0.0%)
settings-writing                     -216 B  (-0.0%)      -53 B  (-0.0%)
marketing                            -193 B  (-0.0%)    -1539 B  (-0.8%)
marketplace                          +192 B  (+0.0%)     +182 B  (+0.1%)
stats                                -144 B  (-0.0%)      -28 B  (-0.0%)
settings-security                    -135 B  (-0.0%)      -63 B  (-0.0%)
posts-custom                         -135 B  (-0.0%)     -107 B  (-0.1%)
posts                                -135 B  (-0.0%)     -107 B  (-0.1%)
activity                             -135 B  (-0.0%)      -15 B  (-0.0%)
gutenberg-editor                     +130 B  (+0.0%)      +63 B  (+0.0%)
settings                             -123 B  (-0.0%)     +852 B  (+0.4%)
theme                                -114 B  (-0.0%)      -42 B  (-0.0%)
plans                                +105 B  (+0.0%)       +8 B  (+0.0%)
devdocs                               -43 B  (-0.0%)      -16 B  (-0.0%)
people                                +41 B  (+0.0%)     -419 B  (-0.3%)
site-purchases                        -21 B  (-0.0%)       -7 B  (-0.0%)
purchases                             -21 B  (-0.0%)       -7 B  (-0.0%)
purchase-product                      -21 B  (-0.0%)       -7 B  (-0.0%)
jetpack-search                        -21 B  (-0.0%)      +55 B  (+0.0%)
jetpack-cloud-settings                -21 B  (-0.0%)       -7 B  (-0.0%)
jetpack-cloud-pricing                 -21 B  (-0.0%)      -86 B  (-0.1%)
jetpack-cloud-partner-portal          -21 B  (-0.0%)       -7 B  (-0.0%)
jetpack-cloud-agency-dashboard        -21 B  (-0.0%)       -7 B  (-0.0%)
help                                  -21 B  (-0.0%)       -7 B  (-0.0%)
email                                 -21 B  (-0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1328 bytes removed 📉 [gzipped])

name                                                              parsed_size           gzip_size
async-load-calypso-post-editor-editor-media-modal                    -41290 B  (-2.3%)   -11639 B  (-2.6%)
async-load-calypso-post-editor-media-modal                           -41065 B  (-2.4%)   -11546 B  (-2.8%)
async-load-design-blocks                                             -39936 B  (-1.7%)   -11322 B  (-1.9%)
async-load-signup-steps-domains                                       -1377 B  (-0.3%)      -84 B  (-0.1%)
async-load-signup-steps-plans                                          +848 B  (+0.3%)     +416 B  (+0.5%)
async-load-calypso-my-sites-checkout-modal                             +359 B  (+0.0%)     +139 B  (+0.0%)
async-load-signup-steps-import-from                                    +348 B  (+0.0%)     +239 B  (+0.1%)
async-load-calypso-blocks-editor-checkout-modal                        +269 B  (+0.0%)     +119 B  (+0.0%)
async-load-calypso-components-web-preview-component                    -253 B  (-0.0%)     -112 B  (-0.1%)
async-load-calypso-reader-sidebar                                      -135 B  (-0.1%)      -57 B  (-0.2%)
async-load-calypso-my-sites-current-site-notice                        -135 B  (-0.1%)      -54 B  (-0.2%)
async-load-calypso-blocks-jitm-templates-sidebar-banner                -135 B  (-0.2%)      -58 B  (-0.3%)
async-load-calypso-blocks-jitm-templates-notice                        -135 B  (-0.2%)      -60 B  (-0.3%)
async-load-calypso-blocks-jitm-templates-default                       -135 B  (-0.2%)      -58 B  (-0.3%)
async-load-calypso-my-sites-site-settings-seo-settings-form            -114 B  (-0.0%)      -27 B  (-0.0%)
async-load-signup-steps-design-picker                                   +65 B  (+0.0%)      +31 B  (+0.1%)
async-load-calypso-layout-masterbar-checkout-tsx                        +48 B  (+0.0%)       +6 B  (+0.0%)
async-load-calypso-layout-masterbar-checkout                            +48 B  (+0.0%)       +6 B  (+0.0%)
async-load-calypso-blocks-inline-help-popover                           +48 B  (+0.0%)       +6 B  (+0.0%)
async-load-masterbar-cart-masterbar-cart-wrapper                        -21 B  (-0.0%)       -7 B  (-0.0%)
async-load-calypso-my-sites-current-site-stale-cart-items-notice        -21 B  (-0.0%)       -7 B  (-0.0%)
async-load-signup-steps-theme-selection                                 +16 B  (+0.0%)       +7 B  (+0.0%)
async-load-calypso-blocks-product-purchase-features-list                +15 B  (+0.0%)       +1 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[gmovr]

This works well - LGTM!

Did the above party trick with my sandbox. Then I tested on a Pro plan site, and upgraded a Free to Business, and then tried to activate hosting. One thing I saw is that if I go to this screen /hosting-config/activate/ on a site that already has hosting activated, it shows a message that it's installing. Though users won't reach that screen if they have hosting activated already.

[gmovr]

Ref my above comment -- the same happens on WordPress.com prod, so that seems unrelated. LGTM! 🚢