-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan Overhaul revert #64370
Plan Overhaul revert #64370
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~261 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2722 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~16120 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@chickee0311 Could you test this via the live link -- and map out any references to Pro/Starter? |
Merged in #64400 |
77f42a2
to
8a4243d
Compare
This PR modifies the release build for editing-toolkit To test your changes on WordPress.com, run To deploy your changes after merging, see the documentation: PCYsg-mMA-p2 |
10f3ed3
to
fb548d2
Compare
fb548d2
to
1fa13d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be good from KitKat perspective, with one minor suggestion.
@@ -19,7 +19,11 @@ import { apiDeleteSite } from '../shared'; | |||
|
|||
declare const browser: Browser; | |||
|
|||
describe( | |||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: @claudiucelfilip another way to disable a test without having to disable waking rules are to simply remove the "@group" from the JSDoc header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: @claudiucelfilip another way to disable a test without having to disable waking rules are to simply remove the "@group" from the JSDoc header.
Thanks for this!
dc5e519
to
b07dbb3
Compare
…tice will be removed (#64400)
* Disable Pro and Starter config flags * Removing this check for now in the renew spec-- as the legacy plan notice will be removed (#64400) * Swapping out the copy for pro plan in editing toolkit Co-authored-by: Claudiu Filip <claudiucelfilip@gmail.com> Co-authored-by: Even Tobiesen <52675688+gmovr@users.noreply.github.com>
* Use starter plan copy overrides in all sitations * Mention paid annual plans instead of just paid
…plan (#64606) * Remove unnecessary redirect and Plans navigations tab hide * Remove overhauled plans grid from the Plans page
* Restore old copy versions * Ensure transfer price is not shown for new annual plans copy
b07dbb3
to
8ee8e49
Compare
This reverts commit c2d28f5.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/7450970 Hi @claudiucelfilip, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
Proposed Changes
Addresses 779-gh-Automattic/martech
plans/pro-plan
andplans/starter-plan
flags for all environmentsTesting Instructions
/start/plans
/plans/[siteid]
TODO
paid plans
,Pro plan
orStarter plan
mentions are rolled back to the previous texts (ex. Business plan)