Desktop: Experiments (v24) #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjangda
added
[Status] In Progress
[Feature] WordPress Desktop App
mjangda
force-pushed
the
try/desktop-experiments-v24
branch
2 times, most recently
from
faf7c53 to
e8ba81e
Compare
Also removes sticky state when mobile viewport is detected, otherwise components like EditorGroundControl could get stuck in an incorrect state. (Obscuring the UI.)
Discover replaces it
Remove Freshly Pressed link from Reader sidebar and swap out other links with `/discover` instead.
This is no longer necessary as `lib/xhr-proxy-request` unifies the error handling.
Previously disabling a feature would leave it enabled in the /me sidebar, but pointing at an Atlas URL. These are all now in Calypso and the feature detection should show or hide the item.
If `premium-plans` is disabled then show a plain text upsell page
`require( 'ipc' )` is deprecated, and the new way is to include electron
It fell out of the merge
This allows us to swap the notifictions over to OAuth without needing a cookie
This patch switches a number of external links in the reader to use the ExternalLink component. In one case, it does not (the timestamp in PostByline) because the default ExternalLink forces an icon size of 18, which doesn't work in the 14px byline. We could add a size param to ExternalLink, but this patch is simpler without it.
mjangda
force-pushed
the
try/desktop-experiments-v24
branch
from
f533302 to
76d7866
Compare
This was referenced Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @johngodley: This it the desktop bucket-o-fun where all experimental code is dumped before pushing out to PRs.
It's probably not worth commenting on anything here 😄