Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: fix small gap between masterbar and content. #491

Merged
merged 1 commit into from
Nov 23, 2015

Conversation

mtias
Copy link
Member

@mtias mtias commented Nov 23, 2015

This was caused by the recent layout update, and the editor is still using the old value.

image

This was caused by the recent layout update, and the editor
is still using the old value.
@mtias mtias added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR labels Nov 23, 2015
@aduth
Copy link
Contributor

aduth commented Nov 23, 2015

These changes look good 👍

Do we also need to update the threshold used by the toolbar scroll pinning?

@aduth aduth added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 23, 2015
mtias added a commit that referenced this pull request Nov 23, 2015
Editor: fix small gap between masterbar and content.
@mtias mtias merged commit 20a546d into master Nov 23, 2015
@mtias mtias deleted the fix/editor-padding branch November 23, 2015 13:22
@mtias
Copy link
Member Author

mtias commented Nov 23, 2015

Let me see...

@mtias
Copy link
Member Author

mtias commented Nov 23, 2015

I don't think we need to.

@mkaz mkaz restored the fix/editor-padding branch November 23, 2015 14:53
mkaz added a commit that referenced this pull request Nov 23, 2015
@lancewillett lancewillett deleted the fix/editor-padding branch December 22, 2015 19:12
@lancewillett lancewillett removed the [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR label Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Post/Page Editor The editor for editing posts and pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants