Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Order: Clean up table view on smaller screens #22556

Merged
merged 4 commits into from
Feb 27, 2018

Conversation

ryelle
Copy link
Member

@ryelle ryelle commented Feb 16, 2018

Fixes #17910 - improves the layout of the order details page on small screens. This updates the line items so that the product name spans the full width, any coupons applied also span the full width of the screen, and the payment & fulfillment buttons wrap to a new line. The "activity log" & address sections work without any adjustments.

Before After
screen shot 2018-02-16 at 16 51 48 order

To test

On a screen or browser smaller than 660px wide…

This doesn't help the create or edit screen, or refunds, or the shipping label modal, this is just for the single order view.

@ryelle ryelle added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR Store labels Feb 16, 2018
@ryelle ryelle self-assigned this Feb 16, 2018
@matticbot
Copy link
Contributor

@ryelle ryelle requested a review from a team February 16, 2018 21:45
@shaunandrews
Copy link
Contributor

shaunandrews commented Feb 16, 2018

The layout is much better. The "Cost" heading does look a little out of place. Maybe just ditch it? Also, do we need to show the cost at all if the quantity is 1?

However, the layout on the FEE row looks off now — it looks better before. Can we have it both ways?

@shaunandrews
Copy link
Contributor

Oh, and maybe the quantity and total should align themselves to the top of their cell?

@ryelle
Copy link
Member Author

ryelle commented Feb 16, 2018

Quantity & total are aligned to the top, the product title is full-width – it's just that those are shorter products. This is a longer example:

screen shot 2018-02-16 at 5 03 22 pm

@shaunandrews
Copy link
Contributor

Ah, I see now. I think its overall a better layout that what you have currently.

@jameskoster
Copy link
Contributor

jameskoster commented Feb 19, 2018

This is an improvement for sure, but I'd prefer us to ditch the table altogether on mobile and do something similar to @olaolusoga's designs for the app - p99K0U-pu

Obviously that's quite a bit more work but I think it would be a significant improvement.

@kellychoffman
Copy link
Member

Obviously that's quite a bit more work but I think it would be a significant improvement.

Agree but its outside the scope of this PR and should be added as a separate issue.

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great improvement over what we currently have on small viewports. I say we get this out there and hope we can revisit later and pursue a non-table solution.

@timmyc timmyc added [Status] Ready to Merge and removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 21, 2018
@ryelle ryelle merged commit ab9132e into master Feb 27, 2018
@ryelle ryelle deleted the update/store-order-small-screen branch February 27, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants