Framework: Update React addons dependency if addons are unused #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Framework
[Status] Needs Review
|
Looks like the script had been a bit overzealous in the case where addons was used directly from the require statement. This is pretty poor form (which I can say as the author of the case 😄 ), and is fixed/improved in 23c51b0. Also did a manual scan over all remaining instances of |
|
Tested, read through all remaining
|
ockham
added
[Status] Ready to Merge
and removed
[Status] Needs Review
ockham
force-pushed
the
remove/react-addons-unused
branch
from
41ff5b1 to
a4bcc71
Compare
ockham
force-pushed
the
remove/react-addons-unused
branch
from
a4bcc71 to
96396db
Compare
|
Rebased. |
👍 |
ockham
added a commit
that referenced
this pull request
Dec 23, 2015
Framework: Update React addons dependency if addons are unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1498, #1878, #1901
This pull request seeks to change the declared dependency of React from
react/addonstoreactif the file does not use any methods fromReact.addons. React addons were moved to separate packages in React 0.14 and currently cause warnings to appear in development environments.Implementation notes:
These replacements were made programmatically using the following script: https://gist.github.com/aduth/8fee70ba5719d48d6b7f
Testing instructions:
Assuming the replacements are valid, there should be no effective change in the application.