Framework: Replace React.addons.PureRenderMixin with react-pure-render #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Framework
[Status] Needs Review
| @@ -1,7 +1,8 @@ | |||
| /** | |||
| * External Dependencies | |||
| */ | |||
| var React = require( 'react/addons' ), | |||
There was a problem hiding this comment.
How did React.createClass work before if React was react/addons ?
Did react/addons contain react as well?
There was a problem hiding this comment.
Did
react/addonscontain react as well?
Yes, react/addons is essentially a superset of React which adds the addons property methods.
ockham
force-pushed
the
remove/react-addons-pure-render
branch
from
09bc649 to
0423395
Compare
|
Rebased. |
|
AFAICS, LGTM :-) |
|
At second glance, |
|
I'll file a PR for |
|
Thanks @ockham ! I'll add the CREDIT and merge shortly thereafter. |
aduth
force-pushed
the
remove/react-addons-pure-render
branch
from
3878474 to
dded938
Compare
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
aduth
added a commit
that referenced
this pull request
Dec 21, 2015
Framework: Replace React.addons.PureRenderMixin with react-pure-render
This was referenced Dec 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to replace
React.addons.PureRenderMixinwith thereact-pure-renderpackage. React addons were moved to separate packages in React 0.14 and currently cause warnings to appear in development environments. Facebook offers its ownreact-addons-pure-render-mixinpackage, but I suggest here that we use thereact-pure-renderpackage instead, as it includes a few useful variations for usage (i.e. function for use in React component classes).Testing instructions:
Code verification:
/addonssuffix in React import accurately reflects current existence of addon usage.React.addons.PureRenderMixinremainsNext steps:
We should replace
shallowequalusage withreact-pure-renders ownreact-pure-render/shallowEqualmodule (see #1463, cc @ockham )