Sharing: fix connecting conflicting accounts #12707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwwar
added
[Feature] Sharing
|
Test live: https://calypso.live/?branch=fix/fb-connect |
|
Thanks @jhnstn since this bug is rather severe I'm going to go ahead and 🚢 this. We can iterate on the warning message in another PR if folks would like changes |
matticbot
removed
[Status] Needs Design Review
aduth
reviewed
Apr 3, 2017
| status="is-warning" | ||
| icon="notice" | ||
| text={ this.props.translate( 'The marked connection will be replaced with your selection.' ) } | ||
| isCompact /> |
There was a problem hiding this comment.
Would we have needed to apply showDismiss={ false } since the default is true and previously we'd disabled it? Or are styles hiding the dismiss?
There was a problem hiding this comment.
Looking at https://wpcalypso.wordpress.com/devdocs/design/notices I don't believe compact notices have a dismiss option, I could add it if it's more clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where clicking on "Add a different account" will crash the page when adding an additional account that has a conflict. Eg, we've added a Facebook account, but we want to replace add a Facebook Page that's already linked to the account.
Testing Instructions
In prod this will hard crash your browser, since we get into an infinite loop.
Notes
It appears that a dispatch to display a warning notice in render was causing this to explode. As an alternative I opted for an inline notice. Design suggestions are welcome. @obenland suggested that maybe we should just update the instruction text in this case?