Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing: can't connect a second account #12306

Closed
wants to merge 4 commits into from
Closed

Sharing: can't connect a second account #12306

wants to merge 4 commits into from

Conversation

gwwar
Copy link
Contributor

@gwwar gwwar commented Mar 20, 2017 •
edited
Loading

This PR fixes an issue where clicking on "Add a different account" will crash the page when the account has a Facebook page. @obenland we fixed the crash, but do you mind 👀 this diff is still incomplete and breaks the add a different account flow.

To Reproduce

Expected: Clicking proceeds through connection flow
Actual: Page will crash in prod with a setState loop

@gwwar gwwar added [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Status] In Progress labels Mar 20, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=try/fix-multiple-social-accounts

@gwwar gwwar requested a review from aduth March 20, 2017 01:21
@obenland
Copy link
Member

Based on the error message it creates I think it is related to this notice. Removing it fixes the problem, but I've not been able to come up with a better solution. I tried moving it to componentWillReceiveProps and componentDidUpdate but that would not fix it either :(

@obenland
Update action button after connecting conflicting account
6a48565 
Fixes a bug where the serve-action button wouldn’t update from
`Connecting…` to `Connected`, because the amount of connections didn’t
change since we replaced one account with another.
@matticbot matticbot added the [Size] S Small sized issue label Mar 26, 2017
@gwwar
Copy link
Contributor Author

gwwar commented Mar 31, 2017

closing in favor of #12707

@gwwar gwwar closed this Mar 31, 2017
@gwwar gwwar deleted the try/fix-multiple-social-accounts branch March 31, 2017 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth Awaiting requested review from aduth

Assignees

@jhnstn jhnstn

@gwwar gwwar

Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. [Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gwwar @matticbot @obenland @jhnstn