Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invertSelf to the DOMMatrix object #1649

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Add invertSelf to the DOMMatrix object #1649

merged 3 commits into from
Aug 19, 2020

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Aug 13, 2020

This should address #1648 by adding the implementation for invertSelf().

  • added tests for inverse() and invertSelf()
  • added the change to the unreleased added section of the Changelog

@Pomax
Copy link
Contributor Author

Pomax commented Aug 13, 2020

I have no idea what Mocha/Node wants me to do here to make the tests pass. I've used the exact same code and style as used in the rest of the tests, and yet it complains about a syntax error, where there literally are no syntax errors.

Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other tiny suggestion while you're at it. Thanks for implementing this!

@Pomax Pomax requested review from chearon and zbjornson August 14, 2020 17:47
@Pomax
Copy link
Contributor Author

Pomax commented Aug 14, 2020

PR updated.

@Pomax
Copy link
Contributor Author

Pomax commented Aug 18, 2020

@zbjornson? =)

Copy link
Collaborator

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Math checks out. Thanks 👏

@zbjornson zbjornson merged commit 595d559 into Automattic:master Aug 19, 2020
@Pomax Pomax deleted the patch-1 branch August 19, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants