Sharedaddy: Protect against malformed from names.

[georgestephanis]

Avoid syntax errors due to unexpected characters in the from name by
base64encoding the from name if any blacklisted characters are used
or it's non-ASCII.

[rcoll]

Looks good except the syntax error.

[rcoll]

I'm getting the following fatal:

2017/03/28 12:09:48 [error] 14282#0: *231580 FastCGI sent in stderr: "PHP message: PHP Parse error: syntax error, unexpected ')' in /var/www/sometestsite.com/wp-content/plugins/jetpack/modules/sharedaddy/sharedaddy.php on line 38" while reading response header from upstream, client: 73.204.197.29, server: sometestsite.com, request: "GET / HTTP/1.1", upstream: "fastcgi://unix:/var/run/php-fpm/php-fpm.sock:", host: "sometestsite.com"

Looks like we don't need the parenthesis here.

[zinigor]

I have fixed the syntax error and @georgestephanis if you don't mind I have split the condition into more lines to improve readability. Testing with this snippet:

add_filter( 'sharing_email_can_send', function( $data ) {
	$data['name'] = "Игорь<\r\n";
	return $data;
} );

What's interesting is that even if you add text after CR and LF symbols, the email gets sent anyway, it just comes without a parsed From header because it gets split into several lines.

Anyway, works great!

[zinigor]

LGTM!

Addressed by @zinigor in 88a87d0

[georgestephanis]

@rcoll D'oh! This is what happens when I do a last minute readability change after testing it. Thanks for the catch!