Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPCOM Widgets Merge -- 22march2017 #6721

Merged
merged 41 commits into from
Mar 28, 2017
Merged

Conversation

georgestephanis
Copy link
Member

This handles the sync of wpcom changes to Jetpack, but explicitly omits the wordpress-post-widget because of the huge overhaul merged in #3207

Andrew Duthie and others added 30 commits March 22, 2017 13:43
…or unknown locale

See: r117058
See: https://[private link]

Merges r120105-wpcom.
…eas wider than 340px.

We recently removed the width option from this widget in order to allow it to be responsive. However, it defaults to 340px at largest, which is a problem for wider widget areas.

This is a partial revert of r119494-wpcom.

https://[private link]
ed2c2a9
https://[private link]#comment-33575

Merges r121114-wpcom.
…Box" to read "Page Plugin" instead, since the code now loads the Facebook page plugin code instead.

Merges r123111-wpcom.
Conflicts:
	modules/widgets/facebook-likebox.php
Conflicts:
	modules/widgets/gallery.php
Conflicts:
	modules/widgets/gravatar-profile.php
Conflicts:
	modules/widgets/social-media-icons.php
…ar fallback image size of 200 pixels square.

FIxes #6664.

Merges r148090-wpcom.
Conflicts:
	modules/widgets/top-posts.php
This is just a stopgap until we can fully integrate with the new
publish.twitter.com setup.  See https://github.com/Automattic/io/issues/601 for
more info.

Merges r137075-wpcom.
https://[private link]

Merges r137600-wpcom.
Same for height, and a couple of other cleanups.  See:

#3283

Merges r137659-wpcom.
From review at #4198

Merges r137943-wpcom.
@georgestephanis
Copy link
Member Author

georgestephanis commented Mar 22, 2017

The wpcom end of this changeset is in phabricator as D4852-code

Copy link
Contributor

@justinshreve justinshreve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been awhile since I've done anything on .com or with the .com widgets, but the changes LGTM.

@georgestephanis
Copy link
Member Author

Yarp, some of these were way out of date -- aa1330b was originally from 2015.

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only included commit isn't included in changes, so guessing it was merged separately. Noted one potential issue from rest of changes though.


return $offsetted_events;
$ical = new iCalendarReader();
return $ical->apply_timezone_offset( $events );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this method defined in iCalendarReader ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the commits and merged them over. Thanks!

Omar Jackman and others added 3 commits March 27, 2017 20:11
This patch adds changes to the calendar shortcode so that it applies a users timezone to all of the rendered events

See https://[private link]
Differential Revision: https://[private link]

Merges r151822-wpcom.
This revision aims at fixing an issue in the `iCalendarReader` class
The function that applies timezone offsets calculates the time difference for timezones using the current date instead of the date thats actually associated with the event. This leads to Daylight Savings Time confusions if today is standard time and the event occurs in daylight savings time. Today (3-8-2017) an event for 3-15-2017 6:30pm will show up as 3-15-2017 5:30pm

For effected users see:
  - https://[private link]
  - https://[private link]
  - https://[private link]

Merges r152463-wpcom.
Must have been a merge gone bad.
@jeherve jeherve added the [Status] Needs Review This PR is ready for review. label Mar 27, 2017
@eliorivero
Copy link
Contributor

LGTM 🐑

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 27, 2017
@samhotchkiss
Copy link
Contributor

Looks like travis got his act together finally!

@samhotchkiss samhotchkiss merged commit bf9cb85 into master Mar 28, 2017
@samhotchkiss samhotchkiss deleted the widgets/merge-22march2017 branch March 28, 2017 02:59
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 28, 2017
jeherve added a commit that referenced this pull request Mar 28, 2017
samhotchkiss pushed a commit that referenced this pull request Mar 29, 2017
* Readme: remove old release and add skeleton for 4.8.

* Changelog: add #6572

* Changelog: add #6567

* Changelog: add #6542

* Changelog: add #6527

* Changelog: add #6508

* Changelog: add #6478

* Changelog: add #6477

* Changelog: add #6249

* Update stable version and remove old version from readme.

* Changelog: add 4.7.1 to changelog.

* Readme: add new contributor.

* Sync: update docblock @SInCE version.

Related: #6053

* Changelog: add release post.

* changelog: add #6053

* Changelog: add #6413

* Changelog: add #6482

* Changelog: add #6584

* Changelog add #6603

* Changelog: add #6606

* Changelog: add #6611

* Changelog: add #6635

* Changelog: add #6639

* Changelog: add #6684

* Changelog: add #6710

* Changelog: add #6711

* Changelog: add #5461

* Testing list: update Settings UI feedback prompt.

Props @MichaelArestad

* Changelog: add #6789

* Changelog: add #6778

* Changelog: add #6777

* Changelog: add #6775

* Changelog: add #6755

* Changelog: add #6731

* Changelog: add #6721

* Changelog: add #6705

* Changelog: add #6702

* Changelog: add #6671

* Changelog: add #6637

* Changelog: add #6582

* Changelog: add #6566

* Changelog: add #6555

* Changelog: add #6529

* Changelog: add #6344

* Changelog: add #5763

* Changelog: add #5503

* Changelog: update #6637 changelog.

@see 40e115c#commitcomment-21523982

* Changelog: add #6699

* Changelog: add #6632

* Changelog: add #6769

* Changelog: add #6707

* Changelog: add #6590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants