Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Height adjust to Admin bar stats link #6443

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Height adjust to Admin bar stats link #6443

merged 1 commit into from
Feb 21, 2017

Conversation

neilorangepeel
Copy link
Contributor

Now the link sites flush inside the admin bar

Fixes #

Changes proposed in this Pull Request:

  • Small edit to css changing height from 28px to 32px (new height of wp-admin bar).

@neilorangepeel
Height adjust to Admin bar stats link
e937548 
Now the link sites flush inside the admin bar
@jeherve
Copy link
Member

jeherve commented Feb 20, 2017

Now the link sites flush inside the admin bar

Would you mind sharing some before / after screenshots, so we can all understand what issue this is fixing? It would also help if you could let us know in which browser you're experiencing those issues?

Thanks!

@jeherve jeherve added [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] Low [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Type] Bug When a feature is broken and / or not performing as intended labels Feb 20, 2017
@neilorangepeel
Copy link
Contributor Author

Before
before

After
after

Link now is equal height to admin bar and other sibling links.

Browsers (latest)
Chrome, Safari, Firefox, Opera on macOS

@jeherve
Copy link
Member

jeherve commented Feb 20, 2017

Thank you!

@jeherve jeherve added [Status] Needs Design Review Design has been added. Needs a review! [Status] Needs Review This PR is ready for review. and removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Feb 20, 2017
@dereksmart
Copy link
Member

Wow, nice eye. Confirmed this fixes it

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Feb 20, 2017
@MichaelArestad MichaelArestad removed the [Status] Needs Design Review Design has been added. Needs a review! label Feb 20, 2017
@samhotchkiss samhotchkiss merged commit 5838525 into Automattic:master Feb 21, 2017
@samhotchkiss samhotchkiss added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Feb 21, 2017
@samhotchkiss
Copy link
Contributor

Thanks, @neilorangepeel !

jeherve added a commit that referenced this pull request Feb 28, 2017
@jeherve
Changelog: add #6443
4a533f7
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

Assignees
No one assigned
Labels
[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Pri] Low [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neilorangepeel @jeherve @dereksmart @samhotchkiss @MichaelArestad